In D8725#130162, @mjacob wrote:In D8725#130160, @martinvonz wrote:Could you include in the commit message which commit added the code and which commit made it unnecessary? "the previous patch/commit" is an okay way of saying that , IMO, even though it requires the reviewer to queue the two patches right after each other for the description to make sense.
In this case, I could use the Differential revision (D8724) to refer to the other patch. Would that also make sense? (I wonder why you didn’t mention this possibility — is it because the repository should be self-contained?)
Active Repositories
Active Repositories
- rNRWHG narrowhg
- 369 Commits
- ·
- Restricted Project
- Jan 26 2018, 6:48 PM
- Mercurial
Recent Activity
Recent Activity
Today
Today
martinvonz added a comment to D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.
mjacob added a comment to D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.
In D8725#130160, @martinvonz wrote:Could you include in the commit message which commit added the code and which commit made it unnecessary? "the previous patch/commit" is an okay way of saying that , IMO, even though it requires the reviewer to queue the two patches right after each other for the description to make sense.
martinvonz added a comment to D8725: rebase: remove now unnecessary logic to allow empty commit when branch changes.
Could you include in the commit message which commit added the code and which commit made it unnecessary? "the previous patch/commit" is an okay way of saying that , IMO, even though it requires the reviewer to queue the two patches right after each other for the description to make sense.
martinvonz added a comment to D8721: scmutil: allowing different files to be prefetched per revision.
Should we have an entry in the release notes about this or have we given up on documenting API changes? I'm fine with either, as long as we have some policy.
joerg.sonnenberger updated the diff for D8575: hooklib: fix detection of successors for changeset_obsoleted.
tests: make names in test-stdio.py more distinctive
mjacob committed rHG65b0784dea6c: tests: terminate subprocess in test-stdio.py in case of exception.
tests: terminate subprocess in test-stdio.py in case of exception
tests: proof test-stdio.py against buffer fill-up
fix: prefetch file contents
fix: obtain base paths before starting workers
tests: stablize test-serve.t on Windows
commitctx: document the manifest writing function
marmoute committed rHGd4db0230e568: commitctx: reorder some conditional for efficiency in _filecommit.
commitctx: reorder some conditional for efficiency in _filecommit
commitctx: document _filecommit input and output
phases: replace magic number by constant
joerg.sonnenberger committed rHG9c7ff8877592: clonebundles: optional memory-requirement attribution.
clonebundles: optional memory-requirement attribution
util: provide a helper function to estimate RAM size
tests: allow timing difference in output
marmoute committed rHG6c22f3ab2fcb: documentation: add some internals documentation about bid merge.
documentation: add some internals documentation about bid merge
rdamazio committed rHG2fac78d5ae87: scmutil: allowing different files to be prefetched per revision.
scmutil: allowing different files to be prefetched per revision
D8723: fix: prefetch file contents is now accepted and ready to land.
D8722: fix: obtain base paths before starting workers is now accepted and ready to land.
D8720: tests: stablize test-serve.t on Windows is now accepted and ready to land.
D8645: clonebundles: optional memory-requirement attribution is now accepted and ready to land.
D8644: util: provide a helper function to estimate RAM size is now accepted and ready to land.