Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

D8144: tests: stabilize test-amend.t on Windows is now accepted and ready to land.
Tue, Feb 25, 6:17 AM
D8142: setup: exclude the __index__ module from itself when generating is now accepted and ready to land.
Tue, Feb 25, 6:16 AM
pulkit added a comment to D8148: revlog-compression: update the config to be a list.

Looks good to me, can you add an entry to relnotes/next?

Tue, Feb 25, 6:12 AM
marmoute created D8148: revlog-compression: update the config to be a list.
Tue, Feb 25, 5:15 AM
marmoute added a comment to D8134: remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269).

I just mean to use changelog=changelog in the super call... but this actually looks more robust.

Tue, Feb 25, 4:52 AM
marmoute accepted D8144: tests: stabilize test-amend.t on Windows.
Tue, Feb 25, 4:49 AM
marmoute added a comment to D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.

Thanks for adding the test.

Tue, Feb 25, 3:46 AM
Alphare retitled D8143: rust-cpython: make `NonNormalEntires` iterable to fix `fsmonitor` (issue6276) from rust-cpython: make `NonNormalEntires` iterable to fix bug with `fsmonitor` to rust-cpython: make `NonNormalEntires` iterable to fix `fsmonitor` (issue6276).
Tue, Feb 25, 3:18 AM
martinvonz added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Makes sense for why it was missed, but I bisected it back to the referenced commit. I know @martinvonz made some other related changes prior to that commit that had similar test fallout on Windows, but it isn't obvious to me why the referenced commit would change the order of when the background thread spins up.

Perhaps the line doesn't actually happen before that commit? You can try removing the (?) in the commit before my commit and see if that line is actually printed. I'm thinking that that commit pushed the number of files to close above some threshold that made it get printed. In that case, it was probably some of my earlier commits that made it no longer get printed and we just didn't notice since (?) means optional (no error if it doesn't get printed).

I can confirm that it was required in e1ecfc7c84be, and reconfirmed that it is needed in the latest code by removing the line from both. I'm not too worried about why it popped up- it just seemed odd that it didn't with the earlier followup patch I added to fix similar conditionalizing of this exact text elsewhere, and the commit where it started failing looked innocuous.

Tue, Feb 25, 1:05 AM
mharbison72 added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Makes sense for why it was missed, but I bisected it back to the referenced commit. I know @martinvonz made some other related changes prior to that commit that had similar test fallout on Windows, but it isn't obvious to me why the referenced commit would change the order of when the background thread spins up.

Perhaps the line doesn't actually happen before that commit? You can try removing the (?) in the commit before my commit and see if that line is actually printed. I'm thinking that that commit pushed the number of files to close above some threshold that made it get printed. In that case, it was probably some of my earlier commits that made it no longer get printed and we just didn't notice since (?) means optional (no error if it doesn't get printed).

Tue, Feb 25, 1:01 AM
martinvonz added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Makes sense for why it was missed, but I bisected it back to the referenced commit. I know @martinvonz made some other related changes prior to that commit that had similar test fallout on Windows, but it isn't obvious to me why the referenced commit would change the order of when the background thread spins up.

Tue, Feb 25, 12:21 AM

Yesterday

mharbison72 updated the summary of D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
Mon, Feb 24, 8:20 PM
marmoute added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since run-test has no idea where to put (?) line with the surounding change, they often end up preserved at start/end of the changeset section. This is probably just something like that.

Mon, Feb 24, 7:14 PM
marmoute added a comment to D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.

Could we get a test for this? To make sure the hint looks fine and that the error code does not crash ?

The reason I didn't add a test (or see any changes to existing ones) is because the config property is baked into the config file generated by run-tests.py, so it never hits this path. But I did test by hand on Windows.

Mon, Feb 24, 7:07 PM
mharbison72 updated subscribers of D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Mon, Feb 24, 6:55 PM
mharbison72 added a comment to D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.

Could we get a test for this? To make sure the hint looks fine and that the error code does not crash ?

Mon, Feb 24, 6:52 PM
marmoute added a comment to D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.

Could we get a test for this? To make sure the hint looks fine and that the error code does not crash ?

Mon, Feb 24, 6:37 PM
marmoute added a comment to D8146: tests: stabilize test-rename-merge2.t on Windows.

Since the line does not occurs on linux, this probably got affected by some other change without being noticed.

Mon, Feb 24, 6:37 PM
marmoute added a comment to D8147: tests: replace truncate(1) with inline python.

sure

Mon, Feb 24, 6:36 PM
marmoute added a comment to D8143: rust-cpython: make `NonNormalEntires` iterable to fix `fsmonitor` (issue6276).

You need to add (issue6276) in your changeset summary so that the ticket get closed when you land this.

Mon, Feb 24, 6:35 PM
mharbison72 created D8147: tests: replace truncate(1) with inline python.
Mon, Feb 24, 5:47 PM
mharbison72 created D8146: tests: stabilize test-rename-merge2.t on Windows.
Mon, Feb 24, 5:47 PM
mharbison72 created D8145: lfutil: provide a hint if the largefiles/lfs cache path cannot be determined.
Mon, Feb 24, 5:47 PM
mharbison72 added a comment to D8144: tests: stabilize test-amend.t on Windows.

This is meant for stable. The other test fixes I'll submit shortly are for default.

Mon, Feb 24, 4:54 PM
mharbison72 created D8144: tests: stabilize test-amend.t on Windows.
Mon, Feb 24, 4:39 PM
durin42 committed rHGf5c006621f07: merge with stable.
merge with stable
Mon, Feb 24, 1:53 PM
pulkit retitled D7932: debugbackupbundle: introduce command to interact with strip backups from debugstripbackups: introduce command to interact with strip backups to debugbackupbundle: introduce command to interact with strip backups.
Mon, Feb 24, 1:11 PM
pulkit updated the diff for D8134: remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269).
Mon, Feb 24, 1:00 PM
yuja committed rHG98c14f0108b8: py3: fix EOL detection in commandserver.channeledinput.
py3: fix EOL detection in commandserver.channeledinput
Mon, Feb 24, 12:44 PM
Alphare retitled D8143: rust-cpython: make `NonNormalEntires` iterable to fix `fsmonitor` (issue6276) from rust-cpython: make `NonNormalEntires` an iterator to fix bug with `fsmonitor` to rust-cpython: make `NonNormalEntires` iterable to fix bug with `fsmonitor`.
Mon, Feb 24, 12:31 PM
Alphare created D8143: rust-cpython: make `NonNormalEntires` iterable to fix `fsmonitor` (issue6276).
Mon, Feb 24, 12:30 PM
marmoute added a comment to D8117: bookmarks: prevent pushes of divergent bookmarks (foo@remote).

I am also +1 for this change. divergence bookmark are close to "remote" bookmark and should not be exchanged. Especially because it open the way to divergent-divergent-bookmark and other hells.

Mon, Feb 24, 12:06 PM
durin42 added a comment to D8117: bookmarks: prevent pushes of divergent bookmarks (foo@remote).

I'm enthusiastic about this change, and in general a fan of declaring misfeatures in bookmarks exchange bugs. I think it's pretty clear the existing bookmarks exchange behavior isn't right to the point of being buggy.

Mon, Feb 24, 11:50 AM
marmoute added a comment to D8142: setup: exclude the __index__ module from itself when generating.

This looks good to me.

Mon, Feb 24, 10:40 AM
D8134: remotefilelog: add 'changelog' arg to shallowcg1packer.generate (issue6269) now requires changes to proceed.
Mon, Feb 24, 10:40 AM
marmoute added a comment to D8127: graft: always allow hg graft --base . (issue6248).

The usecase looks correct, the test change seems correct and the test is good. I can't think of any issue here.

Mon, Feb 24, 10:36 AM
Alphare updated the diff for D7819: rust-nodemap: core implementation for shortest.
Mon, Feb 24, 8:15 AM
Alphare updated the diff for D8098: rust-nodemap: a method for full invalidation.
Mon, Feb 24, 8:15 AM
Alphare updated the diff for D8097: rust-nodemap: accounting for dead blocks.
Mon, Feb 24, 8:15 AM
Alphare updated the diff for D7798: rust-nodemap: special case for prefixes of NULL_NODE.
Mon, Feb 24, 8:15 AM