Page MenuHomePhabricator

Recent Activity
View All

Today

pulkit added a comment to D8378: rust-chg: add helper to parse instructions sent from server.

Queued the whole series based on @Alphare review. Many thanks to both of you.

Thu, Apr 9, 6:38 AM
D8378: rust-chg: add helper to parse instructions sent from server is now accepted and ready to land.
Thu, Apr 9, 6:36 AM

Yesterday

mharbison72 added a comment to D8388: added file.

This was only for generating tests

Wed, Apr 8, 6:01 PM
mharbison72 added a comment to D8387: one: first commit to review.

This was only for generating tests

Wed, Apr 8, 6:01 PM
mharbison72 added a comment to D8386: one: first commit to review.

This was only for generating tests

Wed, Apr 8, 6:00 PM
mharbison72 created D8389: phabricator: add debug logging to show previous node values in `phabsend`.
Wed, Apr 8, 5:52 PM
mharbison72 updated the summary of D8314: phabricator: add an option to fold several commits into one review (issue6244).
Wed, Apr 8, 5:52 PM
mharbison72 created D8390: tests: move the phabricator auth token to the global config file.
Wed, Apr 8, 5:52 PM
mharbison72 updated the summary of D8388: added file.
Wed, Apr 8, 5:13 PM
mharbison72 updated the summary of D8388: added file.
Wed, Apr 8, 5:13 PM
mharbison72 created D8388: added file.
Wed, Apr 8, 5:13 PM
mharbison72 updated the summary of D8387: one: first commit to review.
Wed, Apr 8, 5:13 PM
mharbison72 updated the diff for D8387: one: first commit to review.
Wed, Apr 8, 5:13 PM
mharbison72 updated the diff for D8387: one: first commit to review.
Wed, Apr 8, 5:13 PM
mharbison72 created D8387: one: first commit to review.
Wed, Apr 8, 5:12 PM
mharbison72 created D8386: one: first commit to review.
Wed, Apr 8, 5:12 PM
Alphare accepted D8384: rust-chg: silence warning about dated coding style.
Wed, Apr 8, 4:48 AM
Alphare added a comment to D8383: rust-chg: update name of the server process.

For (d) [modernizing the codebase], we'll probably want to switch to async-std, but I'm thinking of
upgrading to Tokio 0.2 as an intermediate step since process API isn't
ported to async-std yet. I'm pretty sure future migration to async-std
will be painless compared to the mass rewrite from futures-0.1 to 0.3.

Wed, Apr 8, 4:47 AM
Alphare accepted D8382: rust-chg: send client side umask to server.
Wed, Apr 8, 4:41 AM
Alphare accepted D8381: rust-chg: add config validation and process returned instructions.
Wed, Apr 8, 4:36 AM
Alphare accepted D8380: rust-chg: collect server flags from command arguments.
Wed, Apr 8, 4:23 AM
Alphare accepted D8379: rust-chg: add interface to run "validate" request.
Wed, Apr 8, 4:09 AM
Alphare added a comment to D8378: rust-chg: add helper to parse instructions sent from server.

I had to squint hard at the c code to find any discrepancy, of which there seems to be none.

Wed, Apr 8, 4:03 AM

Tue, Apr 7

martinvonz added a comment to D8376: tests: collect all branch creation in one place in test-copies-chain-merge.t.
In D8376#125174, @pulkit wrote:
In D8376#125173, @marmoute wrote:

I would prefer you wait for planned change to land before you do further change to the file. The coming changes fixes bug and I rather not have to fix too many conflict while doing so.

I already pushed them, I will resolve conflicts on those couple of patches and update them on heptapod.

Tue, Apr 7, 11:30 AM
martinvonz closed D8377: tests: move verification closer to setup in test-copies-chain-merge.t.
Tue, Apr 7, 9:07 AM
martinvonz closed D8376: tests: collect all branch creation in one place in test-copies-chain-merge.t.
Tue, Apr 7, 9:07 AM
martinvonz committed rHG806f1f1ba430: tests: move verification closer to setup in test-copies-chain-merge.t.
tests: move verification closer to setup in test-copies-chain-merge.t
Tue, Apr 7, 9:07 AM
martinvonz committed rHG4e2845d9452d: tests: collect all branch creation in one place in test-copies-chain-merge.t.
tests: collect all branch creation in one place in test-copies-chain-merge.t
Tue, Apr 7, 9:07 AM
pulkit added a comment to D8376: tests: collect all branch creation in one place in test-copies-chain-merge.t.
In D8376#125173, @marmoute wrote:

I would prefer you wait for planned change to land before you do further change to the file. The coming changes fixes bug and I rather not have to fix too many conflict while doing so.

Tue, Apr 7, 9:07 AM
marmoute added a comment to D8376: tests: collect all branch creation in one place in test-copies-chain-merge.t.

I would prefer you wait for planned change to land before you do further change to the file. The coming changes fixes bug and I rather not have to fix too many conflict while doing so.

Tue, Apr 7, 9:03 AM
D8377: tests: move verification closer to setup in test-copies-chain-merge.t is now accepted and ready to land.
Tue, Apr 7, 8:51 AM
D8376: tests: collect all branch creation in one place in test-copies-chain-merge.t is now accepted and ready to land.

I was trying to understand what's going on the test modified here and this patch helped me. Thanks!

Tue, Apr 7, 8:29 AM
spectral committed rHG1756f75873bf: hgk: remove a "b" used on a kwargs expansion, the keys are strs.
hgk: remove a "b" used on a kwargs expansion, the keys are strs
Tue, Apr 7, 6:25 AM
spectral closed D8385: hgk: remove a "b" used on a kwargs expansion, the keys are strs.
Tue, Apr 7, 6:25 AM
D8367: manifest: remove a 20-byte-hash assumption from pure manifest parsing is now accepted and ready to land.
Tue, Apr 7, 5:22 AM
D8385: hgk: remove a "b" used on a kwargs expansion, the keys are strs is now accepted and ready to land.
Tue, Apr 7, 5:18 AM

Mon, Apr 6

spectral created D8385: hgk: remove a "b" used on a kwargs expansion, the keys are strs.
Mon, Apr 6, 6:21 PM
marmoute committed rHGb561f3a68e41: discovery: avoid wrongly saying there are nothing to pull.
discovery: avoid wrongly saying there are nothing to pull
Mon, Apr 6, 1:47 PM
marmoute committed rHGa97156dd4411: discovery: avoid wrongly saying there are nothing to pull.
discovery: avoid wrongly saying there are nothing to pull
Mon, Apr 6, 10:20 AM
yuja created D8384: rust-chg: silence warning about dated coding style.
Mon, Apr 6, 10:19 AM