Today

mharbison72 committed rHG36edfbac7281: relink: use context manager for lock management.
relink: use context manager for lock management
Sat, Jun 23, 3:58 AM
mharbison72 committed rHGe219e355e088: censor: use context manager for lock management.
censor: use context manager for lock management
Sat, Jun 23, 3:58 AM

Yesterday

khanchi97 created D3829: rebase: make dry-run return 1 or 0 according to result.
Fri, Jun 22, 11:30 PM
spectral abandoned D2014: amend: --no-secret overrides phases.new-commit and previous phase.
Fri, Jun 22, 2:31 PM
spectral abandoned D2013: commit: allow --no-secret to override phases.new-commit setting.
Fri, Jun 22, 2:30 PM
spectral abandoned D2017: split: accept a --secret flag to force phase of new commits.
Fri, Jun 22, 2:30 PM
spectral abandoned D2016: split: preserve phase of commit that is being split.
Fri, Jun 22, 2:29 PM
yuja committed rHG3813c6b7337c: templater: remove redundant member variables from templater class.
templater: remove redundant member variables from templater class
Fri, Jun 22, 1:54 PM
yuja committed rHG256581484c7f: templater: resurrect cache of engine instance.
templater: resurrect cache of engine instance
Fri, Jun 22, 1:54 PM
yuja committed rHGf79237942dec: templater: extract template loader to separate class.
templater: extract template loader to separate class
Fri, Jun 22, 1:54 PM
khanchi97 added a comment to D3828: rebase: add **opts to _prepareabortorcontinue.

@pulkit I have added a new argument in _prepareabortorcontinue. Now I think
there is no need to split that patch, if I am not wrong. We can leave this
patch here.
Thanks :)

Fri, Jun 22, 1:13 PM
khanchi97 updated the diff for D3827: rebase: no need to store backup during dry-run while aborting.
Fri, Jun 22, 1:10 PM
khanchi97 updated the diff for D3764: rebase: improve output of --dry-run.
Fri, Jun 22, 12:02 PM
khanchi97 added a comment to D3764: rebase: improve output of --dry-run.
In D3764#59797, @pulkit wrote:

@khanchi97 you should have created a new differential so that we don't loose your earlier patch titled: 'rebase: improve output of --dry-run' which is yet under review.

Fri, Jun 22, 12:00 PM
pulkit added a comment to D3764: rebase: improve output of --dry-run.
In D3764#59425, @pulkit wrote:

Thinking out loud here: I see that --dry-run for rebase will be very useful for automation. How about returning 1 when there are conflicts and returning 0 when there are no conflicts? Also maybe we should add formatter support to the dry-run output for each command so that automation can read the JSON output and tell user what can happen.

I approve of both of these feature suggestions! However, they should be implemented in standalone changesets and not incorporated into this one.

Fri, Jun 22, 10:19 AM
pulkit added a comment to D3764: rebase: improve output of --dry-run.

@khanchi97 you should have created a new differential so that we don't loose your earlier patch titled: 'rebase: improve output of --dry-run' which is yet under review.

Fri, Jun 22, 10:19 AM
pulkit added inline comments to D3828: rebase: add **opts to _prepareabortorcontinue.
Fri, Jun 22, 10:18 AM
khanchi97 updated the diff for D3764: rebase: improve output of --dry-run.
Fri, Jun 22, 10:13 AM
khanchi97 created D3828: rebase: add **opts to _prepareabortorcontinue.
Fri, Jun 22, 10:13 AM
khanchi97 created D3827: rebase: no need to store backup during dry-run while aborting.
Fri, Jun 22, 9:21 AM
yuja committed rHG550b7d110f45: tests: rename and document test-command-template.t.
tests: rename and document test-command-template.t
Fri, Jun 22, 9:15 AM
yuja committed rHG6a8ed5c7e112: tests: fold test-template-filters.t into test-template-functions.t.
tests: fold test-template-filters.t into test-template-functions.t
Fri, Jun 22, 9:15 AM
yuja committed rHGda4508cdef37: tests: extract test-template-keywords.t from test-command-template.t.
tests: extract test-template-keywords.t from test-command-template.t
Fri, Jun 22, 9:15 AM
yuja committed rHG70f551a3f52e: tests: extract test-template-functions.t from test-command-template.t.
tests: extract test-template-functions.t from test-command-template.t
Fri, Jun 22, 9:15 AM
yuja committed rHGddce7bdf7f3c: tests: extract test-template-map.t from test-command-template.t.
tests: extract test-template-map.t from test-command-template.t
Fri, Jun 22, 9:15 AM
pulkit added inline comments to D3825: grep: deprecates `--all` flag.
Fri, Jun 22, 9:00 AM
pulkit added a comment to D3757: rebase: add dry-run functionality.

I was also thinking to add --confirm option. It will show the same output as dry-run but at the end, will ask the user to continue. So that user don't have to write that command again. What do you say?

Fri, Jun 22, 8:45 AM
khanchi97 added a comment to D3757: rebase: add dry-run functionality.

I was also thinking to add --confirm option. It will show the same output as dry-run but at the end, will ask the user to continue. So that user don't have to write that command again. What do you say?

Fri, Jun 22, 8:44 AM
martinvonz closed D3824: cleanupnodes: preserve phase of parents of new nodes.
Fri, Jun 22, 7:44 AM
khanchi97 closed D3756: rebase: delete the comment which was not following "do not eat my data".
Fri, Jun 22, 7:44 AM
martinvonz committed rHG05b7dd11918e: cleanupnodes: preserve phase of parents of new nodes.
cleanupnodes: preserve phase of parents of new nodes
Fri, Jun 22, 7:44 AM
khanchi97 committed rHGd6686f864a70: rebase: delete the comment which was not following "do not eat my data".
rebase: delete the comment which was not following "do not eat my data"
Fri, Jun 22, 7:44 AM
yuja added a comment to D3825: grep: deprecates `--all` flag.
@command('grep',
    [('0', 'print0', None, _('end fields with NUL')),
  • ('', 'all', None, _('print all revisions that match')), + ('', 'all', None, _('print all revisions that match (DEPRECATED)')), ('', 'diff', None, _('print all revisions when the term was introduced or removed')),
Fri, Jun 22, 7:42 AM
khanchi97 updated the diff for D3756: rebase: delete the comment which was not following "do not eat my data".
Fri, Jun 22, 3:08 AM

Thu, Jun 21

sangeet259 added a comment to D3826: grep: change default behaviour of grep.

I need some help with the tests failing here.

Thu, Jun 21, 2:49 PM
sangeet259 retitled D3826: grep: change default behaviour of grep from grep : change default behaviour of grep to grep: change default behaviour of grep.
Thu, Jun 21, 2:48 PM
sangeet259 updated the diff for D3826: grep: change default behaviour of grep.
Thu, Jun 21, 2:45 PM
sangeet259 created D3826: grep: change default behaviour of grep.
Thu, Jun 21, 2:42 PM
martinvonz added inline comments to D3628: status: add default of --terse=u to tweakdefaults (BC).
Thu, Jun 21, 2:09 PM
yuja committed rHG5d9b765dbe15: tags: unblock log-like template keywords and functions.
tags: unblock log-like template keywords and functions
Thu, Jun 21, 1:14 PM