Today

durin42 closed D2390: py3: two more narrow tests passing.
Thu, Feb 22, 1:29 AM
durin42 committed rHG0c34cb461a1e: py3: two more narrow tests passing.
py3: two more narrow tests passing
Thu, Feb 22, 1:29 AM
durin42 closed D2389: narrowbundle2: more kwargs native string fixes.
Thu, Feb 22, 1:29 AM
durin42 committed rHG22f8efbf9e44: narrowbundle2: more kwargs native string fixes.
narrowbundle2: more kwargs native string fixes
Thu, Feb 22, 1:29 AM
durin42 closed D2387: narrowbundle2: use native string to get kwargs from dict.
Thu, Feb 22, 1:29 AM
durin42 committed rHGabbf587f536a: py3: whitelist another 11 passing tests.
py3: whitelist another 11 passing tests
Thu, Feb 22, 1:29 AM
durin42 closed D2388: py3: whitelist another 11 passing tests.
Thu, Feb 22, 1:29 AM
durin42 committed rHGac7873dea67f: narrowbundle2: use native string to get kwargs from dict.
narrowbundle2: use native string to get kwargs from dict
Thu, Feb 22, 1:29 AM
durin42 committed rHGeee738c5a899: narrowbundle2: drop legacy getcgkwargs variable.
narrowbundle2: drop legacy getcgkwargs variable
Thu, Feb 22, 1:29 AM
durin42 closed D2386: narrowbundle2: drop legacy getcgkwargs variable.
Thu, Feb 22, 1:29 AM
indygreg accepted D2390: py3: two more narrow tests passing.
Thu, Feb 22, 1:29 AM
indygreg accepted D2389: narrowbundle2: more kwargs native string fixes.
Thu, Feb 22, 1:29 AM
indygreg accepted D2388: py3: whitelist another 11 passing tests.
Thu, Feb 22, 1:28 AM
indygreg accepted D2387: narrowbundle2: use native string to get kwargs from dict.
Thu, Feb 22, 1:28 AM
indygreg accepted D2386: narrowbundle2: drop legacy getcgkwargs variable.
Thu, Feb 22, 1:28 AM
durin42 created D2390: py3: two more narrow tests passing.
Thu, Feb 22, 1:08 AM
durin42 added a dependent revision for D2389: narrowbundle2: more kwargs native string fixes: D2390: py3: two more narrow tests passing.
Thu, Feb 22, 1:08 AM
durin42 created D2389: narrowbundle2: more kwargs native string fixes.
Thu, Feb 22, 1:08 AM
durin42 added a dependent revision for D2388: py3: whitelist another 11 passing tests: D2389: narrowbundle2: more kwargs native string fixes.
Thu, Feb 22, 1:08 AM

Yesterday

durin42 created D2388: py3: whitelist another 11 passing tests.
Wed, Feb 21, 11:25 PM
durin42 added a dependent revision for D2387: narrowbundle2: use native string to get kwargs from dict: D2388: py3: whitelist another 11 passing tests.
Wed, Feb 21, 11:25 PM
durin42 created D2387: narrowbundle2: use native string to get kwargs from dict.
Wed, Feb 21, 11:25 PM
durin42 added a dependent revision for D2386: narrowbundle2: drop legacy getcgkwargs variable: D2387: narrowbundle2: use native string to get kwargs from dict.
Wed, Feb 21, 11:25 PM
durin42 created D2386: narrowbundle2: drop legacy getcgkwargs variable.
Wed, Feb 21, 11:25 PM
dploch committed rHG2ed36fec5321: fancyopts: add support for custom multi-arg opts in fancyopts.py.
fancyopts: add support for custom multi-arg opts in fancyopts.py
Wed, Feb 21, 11:06 PM
dploch closed D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py.
Wed, Feb 21, 11:06 PM
indygreg accepted D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py.

Thanks for following up with the style changes!

Wed, Feb 21, 10:56 PM
durin42 closed D2367: narrowcommands: add some missing strkwargs calls for py3.
Wed, Feb 21, 10:52 PM
durin42 committed rHG5dbeddbf164a: narrowcommands: add some missing strkwargs calls for py3.
narrowcommands: add some missing strkwargs calls for py3
Wed, Feb 21, 10:52 PM
durin42 committed rHG87e950a070e6: narrowwirepeer: add some strkwargs to fix a crash on py3.
narrowwirepeer: add some strkwargs to fix a crash on py3
Wed, Feb 21, 10:52 PM
durin42 closed D2366: narrowwirepeer: add some strkwargs to fix a crash on py3.
Wed, Feb 21, 10:52 PM
indygreg accepted D2367: narrowcommands: add some missing strkwargs calls for py3.
Wed, Feb 21, 10:51 PM
indygreg accepted D2366: narrowwirepeer: add some strkwargs to fix a crash on py3.
Wed, Feb 21, 10:51 PM
durin42 added a comment to D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py.
In D2090#39120, @dploch wrote:

Out of curiosity, do you think it would be possible to implement an option that behaved like a boolean when given in isolation but also optionally accepted a value? My use case is I want hg serve --open to automatically open a web browser pointing at the started server and hg serve --open chrome to open Chrome instead of my default web browser. I'm not sure if that's a good idea to implement in the parser though. It could possibly lead to ambiguous argument parsing.

It feels like a bad idea. If we want the parsing to be unambiguous, then '--open' must always come at the end of the command line if the default option is desired. If there were a separate flag with the same semantics, you couldn't specify both: 'hg serve --open --foo' would pass "--foo" as the argument to --open.

If we stipulate that the optional argument only counts as an argument if it doesn't look like a flag (^-(-)?[^\d-].*$), it sort of works, but that feels pretty messy.

Wed, Feb 21, 10:27 PM
dploch added a comment to D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py.

Out of curiosity, do you think it would be possible to implement an option that behaved like a boolean when given in isolation but also optionally accepted a value? My use case is I want hg serve --open to automatically open a web browser pointing at the started server and hg serve --open chrome to open Chrome instead of my default web browser. I'm not sure if that's a good idea to implement in the parser though. It could possibly lead to ambiguous argument parsing.

Wed, Feb 21, 10:26 PM
dploch updated the diff for D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py.
Wed, Feb 21, 10:26 PM
durin42 updated the diff for D2367: narrowcommands: add some missing strkwargs calls for py3.
Wed, Feb 21, 10:24 PM
durin42 updated the diff for D2366: narrowwirepeer: add some strkwargs to fix a crash on py3.
Wed, Feb 21, 10:24 PM
indygreg created D2385: wireproto: document the wonky push protocol for SSH.
Wed, Feb 21, 10:23 PM
indygreg created D2384: wireprototypes: move baseprotocolhandler from wireprotoserver.
Wed, Feb 21, 10:23 PM