Today

martinvonz closed D5634: narrow: fix crash when restoring backup in legacy repo.
Sat, Jan 19, 6:39 AM
martinvonz committed rHG88a7c211b21e: narrow: fix crash when restoring backup in legacy repo.
narrow: fix crash when restoring backup in legacy repo
Sat, Jan 19, 6:39 AM
lothiraldan committed rHGb1ea90613af3: revset: introduce an internal `_rev` predicate for '%d' usage.
revset: introduce an internal `_rev` predicate for '%d' usage
Sat, Jan 19, 6:30 AM
lothiraldan added a reverting commit for rHG74a9f428227e: mmapindex: set default to 1MB: rHGbf4a078b3f88: mmap: backed out changeset 74a9f428227e.
Sat, Jan 19, 6:30 AM
lothiraldan committed rHGbf4a078b3f88: mmap: backed out changeset 74a9f428227e.
mmap: backed out changeset 74a9f428227e
Sat, Jan 19, 6:30 AM
lothiraldan committed rHGd82dd55024e7: mmap: backed out changeset 875d2af8cb4e.
mmap: backed out changeset 875d2af8cb4e
Sat, Jan 19, 6:30 AM
lothiraldan added a reverting commit for rHG875d2af8cb4e: mmapindex: move the 'mmapindexthreshold' option out of experimental: rHGd82dd55024e7: mmap: backed out changeset 875d2af8cb4e.
Sat, Jan 19, 6:30 AM
mharbison72 committed rHGb5d7413e4009: help: document the minimumhgversion variable for extensions.
help: document the minimumhgversion variable for extensions
Sat, Jan 19, 6:30 AM
mharbison72 committed rHG86f6b441adea: help: modernize the example for command registration.
help: modernize the example for command registration
Sat, Jan 19, 6:30 AM
martinvonz added a comment to D5634: narrow: fix crash when restoring backup in legacy repo.

This is meant for the stable branch

Sat, Jan 19, 2:53 AM
martinvonz created D5634: narrow: fix crash when restoring backup in legacy repo.
Sat, Jan 19, 2:51 AM

Yesterday

martinvonz created D5633: grep: use set instead of dict with dummy value.
Fri, Jan 18, 2:19 PM
martinvonz updated the diff for D5620: grep: don't look up copy info unless --follow is given.
Fri, Jan 18, 2:11 PM
durin42 committed rHG593718ff5844: merge default into stable for 4.9 release.
merge default into stable for 4.9 release
Fri, Jan 18, 1:37 PM
durin42 committed rHG74525c3e9476: Added signature for changeset 593718ff5844.
Added signature for changeset 593718ff5844
Fri, Jan 18, 1:37 PM
durin42 committed rHG9c290711e175: Added tag 4.9rc0 for changeset 593718ff5844.
Added tag 4.9rc0 for changeset 593718ff5844
Fri, Jan 18, 1:37 PM
martinvonz added a reviewer for D5632: setdiscovery: pass srvheads into partialdiscovery constructor: lothiraldan.
Fri, Jan 18, 1:21 PM
martinvonz created D5632: setdiscovery: pass srvheads into partialdiscovery constructor.
Fri, Jan 18, 1:20 PM
yuja added a comment to D5594: copies: consider nullrev a common ancestor.
There are definitely repositories in the wild where p1 is nullrev (and p2 is not). It's unusual but expressable so, of course, it happened.

For that matters, there is also case with nullrev != p1 && p1 == p2.
Fri, Jan 18, 9:01 AM
lothiraldan added a comment to D5594: copies: consider nullrev a common ancestor.
In D5594#83078, @yuja wrote:
I've seen many bugs in the git codebase that were caused by it not
having a null revision and being forced to treat root commits
differently. Mercurial has a null revision and I think it's generally
a bug to treat it differently from other commits in graph algorithms.

I agree with that, but I don't think every non-merge revision (p2 = null)
should be considered a direct child of null revision.

@@ -65,8 +63,6 @@

else:
    parents = cl.parentrevs(r)

Here parents[1] may be nullrev. Is that expected?

for p in parents:
  • if p < 0:
  • continue
Fri, Jan 18, 8:25 AM
martinvonz closed D5626: scmutil: drop unreachable except clause.
Fri, Jan 18, 7:36 AM
martinvonz closed D5625: tests: suppress "Checked out 1 paths of <hash>" from modern git.
Fri, Jan 18, 7:36 AM
lothiraldan committed rHG593f6359681d: update: fix edge-case with update.atomic-file and read-only files.
update: fix edge-case with update.atomic-file and read-only files
Fri, Jan 18, 7:36 AM
martinvonz committed rHG17941fc53ae9: scmutil: drop unreachable except clause.
scmutil: drop unreachable except clause
Fri, Jan 18, 7:36 AM
martinvonz committed rHGc0221d929eb9: tests: suppress "Checked out 1 paths of <hash>" from modern git.
tests: suppress "Checked out 1 paths of <hash>" from modern git
Fri, Jan 18, 7:36 AM
yuja added a comment to D5626: scmutil: drop unreachable except clause.
socket.error is a subclass of IOError, which we catch higher up. It
Fri, Jan 18, 7:29 AM
yuja added a comment to D5594: copies: consider nullrev a common ancestor.
I've seen many bugs in the git codebase that were caused by it not
having a null revision and being forced to treat root commits
differently. Mercurial has a null revision and I think it's generally
a bug to treat it differently from other commits in graph algorithms.
Fri, Jan 18, 7:14 AM
yuja committed rHG00b314c42094: revlog: document that mmap resources are released implicitly by GC.
revlog: document that mmap resources are released implicitly by GC
Fri, Jan 18, 4:54 AM
yuja committed rHGcf8677cd7286: ui: proxy protect/restorestdio() calls to update internal flag.
ui: proxy protect/restorestdio() calls to update internal flag
Fri, Jan 18, 4:54 AM
yuja committed rHGb0e3f2d7c143: ui: move protectedstdio() context manager from procutil.
ui: move protectedstdio() context manager from procutil
Fri, Jan 18, 4:54 AM
yuja committed rHG4948b327d3b9: cext: clang-format new code coming from stable branch.
cext: clang-format new code coming from stable branch
Fri, Jan 18, 4:54 AM
martinvonz updated the diff for D5629: cleanup: delete lots of unused local variables.
Fri, Jan 18, 2:10 AM
martinvonz created D5631: hghave: let OSError with ENOENT through like any other.
Fri, Jan 18, 2:08 AM
lothiraldan accepted D5622: localrepo: use context manager for transaction in commit().

I have the impression that the test changes are due to the previous patch in the stack.

I don't think so. See commit message for why I think they changed.

Fri, Jan 18, 1:59 AM
martinvonz created D5630: remotefilelog: remove pointless return statement from constructor.
Fri, Jan 18, 1:19 AM

Thu, Jan 17

martinvonz created D5629: cleanup: delete lots of unused local variables.
Thu, Jan 17, 1:29 PM
martinvonz updated the diff for D5620: grep: don't look up copy info unless --follow is given.
Thu, Jan 17, 11:49 AM
lothiraldan added a comment to D5590: watchman: ignore some of watchman errors.

I don't suppose there's a way to easily test this? I'm guessing not...

The change seems reasonable though.

Thu, Jan 17, 11:47 AM
lothiraldan added inline comments to D5589: watchman: add the possibility to set the exact watchman binary location.
Thu, Jan 17, 11:46 AM
lothiraldan added a comment to D5588: watchman: disable fsmonitor when running non-interactively.

Why wouldn't we want automated, non-interactive tools to have the benefits of watchman? There are plenty of use cases where complex Mercurial operations are scripted and would benefit from watchman.

Your commit message details an issue that I assume you encountered in the wild. Are there other ways we can work around this? Perhaps we can set the idle timeout/shutdown interval of watchman to be much smaller when Mercurial is non-interactive?

Thu, Jan 17, 11:36 AM