This is an archive of the discontinued Mercurial Phabricator instance.

Differential D102

cleanobsstore: fix devel-warning
ClosedPublic

Authored by durham on Jul 17 2017, 5:57 AM.
Tags
None
Subscribers
None

Details

Reviewers
simonfar
Group Reviewers
Restricted Project
Commits
rFBHGX858b0fc056b4: cleanobsstore: fix devel-warning
Summary

Upstream now warns when writing a vfs file outside of a lock. For this
particular file, it's safe to write it outside the lock, so let's add it to the
whitelist.

Test Plan

Test now passes

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durham created this revision.Jul 17 2017, 5:57 AM
simonfar accepted this revision.Jul 17 2017, 6:30 AM
This revision is now accepted and ready to land.Jul 17 2017, 6:30 AM
Closed by commit rFBHGX858b0fc056b4: cleanobsstore: fix devel-warning (authored by durham). · Explain WhyJul 17 2017, 7:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/cleanobsstore.py (1 line)

Diff 197

hgext3rd/cleanobsstore.py

from mercurial.i18n import _ from mercurial.i18n import _
_cleanedobsstorefile = b'cleanedobsstore' _cleanedobsstorefile = b'cleanedobsstore'
def reposetup(ui, repo): def reposetup(ui, repo):
if repo.obsstore: if repo.obsstore:
indicestodelete = [] indicestodelete = []
if _needtoclean(ui, repo): if _needtoclean(ui, repo):
repo._wlockfreeprefix.add(_cleanedobsstorefile)
_write(ui, 'your obsstore is big, checking if we can clean it') _write(ui, 'your obsstore is big, checking if we can clean it')
badusernames = ui.configlist('cleanobsstore', 'badusernames') badusernames = ui.configlist('cleanobsstore', 'badusernames')
for index, data in enumerate(repo.obsstore._all): for index, data in enumerate(repo.obsstore._all):
marker = obsutil.marker(repo, data) marker = obsutil.marker(repo, data)
username = marker.metadata().get('user') username = marker.metadata().get('user')
if username: if username:
if username in badusernames: if username in badusernames:
indicestodelete.append(index) indicestodelete.append(index)