This is an archive of the discontinued Mercurial Phabricator instance.

tweakdefaults: take wlock when changing bookmarks
ClosedPublic

Authored by durham on Jul 17 2017, 6:02 AM.
Tags
None
Subscribers

Details

Reviewers
simonfar
Group Reviewers
Restricted Project
Commits
rFBHGX4b771106a9ee: tweakdefaults: take wlock when changing bookmarks
Summary

Upstream has added devel-warnings when writing to vfs files without taking the
wlock. We need to take the wlock here.

Test Plan

The test now passes

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durham created this revision.Jul 17 2017, 6:02 AM
durham updated this revision to Diff 190.Jul 17 2017, 6:06 AM

Better test run

simonfar requested changes to this revision.Jul 17 2017, 6:32 AM
simonfar added a subscriber: simonfar.

Something weird here - Phabricator says you've not changed anything.

This revision now requires changes to proceed.Jul 17 2017, 6:32 AM
simonfar accepted this revision.Jul 17 2017, 6:36 AM

The change has now appeared. Accepting.

This revision is now accepted and ready to land.Jul 17 2017, 6:36 AM
This revision was automatically updated to reflect the committed changes.