diff --git a/contrib/check-code.py b/contrib/check-code.py --- a/contrib/check-code.py +++ b/contrib/check-code.py @@ -363,6 +363,9 @@ (r'([a-z]*).revision\(\1\.node\(', "don't convert rev to node before passing to revision(nodeorrev)"), (r'platform\.system\(\)', "don't use platform.system(), use pycompat"), + (r'pycompat\.osname\s*==\s*[\'"]nt[\'"]', "use pycompat.iswindows"), + (r'pycompat\.osname\s*==\s*[\'"]posix[\'"]', "use pycompat.isposix"), + (r'pycompat\.sysplatform\s*==[\'"]darwin[\'"]', "use pycompat.isdarwin"), # rules depending on implementation of repquote() (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',