This is an archive of the discontinued Mercurial Phabricator instance.

tersestatus: rework dirnode and tersedir docstrings
AbandonedPublic

Authored by dlax on Oct 14 2017, 6:13 AM.
Tags
None
Subscribers
None

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Summary

Follow-up on refactorings 3d6d4b12128e and 5d98674df18a of the original
changeset 7e3001b74ab3 by updating the docstrings of dirnode class and tersedir
function:

  • rewrite dirnode.iterfilepaths()'s docstring (the method got renamed and reimplemented in 5d98674df18a);
  • simplify and update dirnode.tersewalk() to remove reference to 'self' and 'tersedict';
  • use the imperative form of verbs in the first sentence of all docstrings.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

dlax created this revision.Oct 14 2017, 6:13 AM
dlax abandoned this revision.Oct 14 2017, 7:34 AM

Apparently the "herald" thing did not work, sending again.