This is an archive of the discontinued Mercurial Phabricator instance.

dirstate: make sure that status does not overlook the status flags
ClosedPublic

Authored by marmoute on Oct 28 2021, 5:14 PM.

Details

Summary

Without this extra checks, file with fallback flags change as the only change
would be overlooked.

In the future we might store proper data in the dirstate and do less lookup.
However, for now this will do to make sure that 6.0 is forward compatible with
later version.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Oct 28 2021, 5:14 PM
Alphare accepted this revision.Oct 29 2021, 3:52 AM
This revision is now accepted and ready to land.Oct 29 2021, 3:52 AM
baymax updated this revision to Diff 31005.Oct 29 2021, 8:45 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Btw, shouldn't the title be "overlook the fallback flags"? I'll amend this as well