This is an archive of the discontinued Mercurial Phabricator instance.

repack: fix the hg executable location for background repack
ClosedPublic

Authored by singhsrb on Oct 23 2017, 7:44 PM.
Tags
None
Subscribers
None

Details

Summary

The background repack uses the incorrect executable while running the
repack command due to which there are no logs for the background repack. This
commit fixes that by specifying the correct executable.

Test Plan
  • Ran all the tests.
  • Tested the output of util.hgexecutable() with system hg and chg, and verified that it returns the correct path. As expected, util.hgcmd() returns the corresponding path for hg and chg in this case.
  • Did a hg pull on one of the repos and verified that it triggered a background incremental repack.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

singhsrb created this revision.Oct 23 2017, 7:44 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2017, 7:44 PM
quark accepted this revision.Oct 23 2017, 7:49 PM
This revision is now accepted and ready to land.Oct 23 2017, 7:49 PM
This revision was automatically updated to reflect the committed changes.
This comment was removed by singhsrb.