This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Needs Review	martinvonz	D12494 [RFC] rust-revlog: create nodemap on the fly if it's not persisted
Needs Review	martinvonz	D12424 rust: upgrade zstd from 0.5.3 to 0.11.1
Accepted	martinvonz	D12548 changelog: avoid copying changeset data into `ChangesetRevisionData`
Accepted	martinvonz	D12486 rust-nodemap: remove unnecessary explicit lifetime
Needs Review	martinvonz	D12565 rust-revlog: add tests for p1/p2 getters, as promised in D12442
Needs Review	martinvonz	D12564 rust-revlog: make `IndexEntryBuilder` build a whole entry
Needs Review	martinvonz	D12563 rust-revlog: change default version from 2 to 1 in test builder
Needs Review	martinvonz	D12562 rust-repo: extract a function for checking nodemap requirement
Needs Review	martinvonz	D12561 rust-revlog: make `Changelog` and `ManifestLog` unaware of `Repo`
Closed	martinvonz	D12442 rust-revlog: add methods for getting parent revs and entries
Accepted	martinvonz	D12547 rust-revlog: make unaware of `Repo`
Accepted	martinvonz	D12558 rust-filelog: don't use persistent nodemap (to match Python)
Needs Review	martinvonz	D12546 rust-revlog: move check for nodemap requirement to caller
Accepted	martinvonz	D12545 rust-nodemap-docket: make unaware of `Repo`
Accepted	martinvonz	D12544 rust-nodemap-docket: move check of nodemap requirement to caller
Closed	martinvonz	D12439 rust-changelog: start parsing changeset data
Closed	martinvonz	D12438 rust-changelog: remove special parsing of empty changelog data for null rev
Closed	martinvonz	D12426 rust-changelog: don't skip empty lines when iterating over changeset lines
Closed	martinvonz	D12425 rust-requirements: allow loading repos with `bookmarksinstore` requirement

Diff 33184

rust/hg-core/src/repo.rs

	store: store_path,			store: store_path,
	dot_hg,			dot_hg,
	config: repo_config,			config: repo_config,
	dirstate_parents: LazyCell::new(Self::read_dirstate_parents),			dirstate_parents: LazyCell::new(Self::read_dirstate_parents),
	dirstate_data_file_uuid: LazyCell::new(			dirstate_data_file_uuid: LazyCell::new(
	Self::read_dirstate_data_file_uuid,			Self::read_dirstate_data_file_uuid,
	),			),
	dirstate_map: LazyCell::new(Self::new_dirstate_map),			dirstate_map: LazyCell::new(Self::new_dirstate_map),
	changelog: LazyCell::new(Changelog::open),			changelog: LazyCell::new(Self::new_changelog),
	manifestlog: LazyCell::new(Manifestlog::open),			manifestlog: LazyCell::new(Self::new_manifestlog),
	};			};

	requirements::check(&repo)?;			requirements::check(&repo)?;

	Ok(repo)			Ok(repo)
	}			}

	pub fn working_directory_path(&self) -> &Path {			pub fn working_directory_path(&self) -> &Path {
	}			}

	pub fn dirstate_map_mut(			pub fn dirstate_map_mut(
	&self,			&self,
	) -> Result<RefMut<OwningDirstateMap>, DirstateError> {			) -> Result<RefMut<OwningDirstateMap>, DirstateError> {
	self.dirstate_map.get_mut_or_init(self)			self.dirstate_map.get_mut_or_init(self)
	}			}

				fn new_changelog(&self) -> Result<Changelog, HgError> {
				let use_nodemap = self
				.requirements
				.contains(requirements::NODEMAP_REQUIREMENT);
				Changelog::open(&self.store_vfs(), use_nodemap)
				}

	pub fn changelog(&self) -> Result<Ref<Changelog>, HgError> {			pub fn changelog(&self) -> Result<Ref<Changelog>, HgError> {
	self.changelog.get_or_init(self)			self.changelog.get_or_init(self)
	}			}

	pub fn changelog_mut(&self) -> Result<RefMut<Changelog>, HgError> {			pub fn changelog_mut(&self) -> Result<RefMut<Changelog>, HgError> {
	self.changelog.get_mut_or_init(self)			self.changelog.get_mut_or_init(self)
	}			}

				fn new_manifestlog(&self) -> Result<Manifestlog, HgError> {
				let use_nodemap = self
				.requirements
				.contains(requirements::NODEMAP_REQUIREMENT);
				Manifestlog::open(&self.store_vfs(), use_nodemap)
				}

	pub fn manifestlog(&self) -> Result<Ref<Manifestlog>, HgError> {			pub fn manifestlog(&self) -> Result<Ref<Manifestlog>, HgError> {
	self.manifestlog.get_or_init(self)			self.manifestlog.get_or_init(self)
	}			}

	pub fn manifestlog_mut(&self) -> Result<RefMut<Manifestlog>, HgError> {			pub fn manifestlog_mut(&self) -> Result<RefMut<Manifestlog>, HgError> {
	self.manifestlog.get_mut_or_init(self)			self.manifestlog.get_mut_or_init(self)
	}			}

rust/hg-core/src/revlog/changelog.rs

	use crate::errors::HgError;			use crate::errors::HgError;
	use crate::repo::Repo;
	use crate::requirements;
	use crate::revlog::revlog::{Revlog, RevlogEntry, RevlogError};			use crate::revlog::revlog::{Revlog, RevlogEntry, RevlogError};
	use crate::revlog::Revision;			use crate::revlog::Revision;
	use crate::revlog::{Node, NodePrefix};			use crate::revlog::{Node, NodePrefix};
	use crate::utils::hg_path::HgPath;			use crate::utils::hg_path::HgPath;
				use crate::vfs::Vfs;
	use itertools::Itertools;			use itertools::Itertools;
	use std::ascii::escape_default;			use std::ascii::escape_default;
	use std::fmt::{Debug, Formatter};			use std::fmt::{Debug, Formatter};

	/// A specialized `Revlog` to work with `changelog` data format.			/// A specialized `Revlog` to work with `changelog` data format.
	pub struct Changelog {			pub struct Changelog {
	/// The generic `revlog` format.			/// The generic `revlog` format.
	pub(crate) revlog: Revlog,			pub(crate) revlog: Revlog,
	}			}

	impl Changelog {			impl Changelog {
	/// Open the `changelog` of a repository given by its root.			/// Open the `changelog` of a repository given by its root.
	pub fn open(repo: &Repo) -> Result<Self, HgError> {			pub fn open(store_vfs: &Vfs, use_nodemap: bool) -> Result<Self, HgError> {
	let use_nodemap = repo			let revlog =
	.requirements()			Revlog::open(store_vfs, "00changelog.i", None, use_nodemap)?;
	.contains(requirements::NODEMAP_REQUIREMENT);
	let revlog = Revlog::open(
	&repo.store_vfs(),
	"00changelog.i",
	None,
	use_nodemap,
	)?;
	Ok(Self { revlog })			Ok(Self { revlog })
	}			}

	/// Return the `ChangelogEntry` for the given node ID.			/// Return the `ChangelogEntry` for the given node ID.
	pub fn data_for_node(			pub fn data_for_node(
	&self,			&self,
	node: NodePrefix,			node: NodePrefix,
	) -> Result<ChangelogRevisionData, RevlogError> {			) -> Result<ChangelogRevisionData, RevlogError> {

rust/hg-core/src/revlog/manifest.rs

	use crate::errors::HgError;			use crate::errors::HgError;
	use crate::repo::Repo;
	use crate::requirements;
	use crate::revlog::revlog::{Revlog, RevlogError};			use crate::revlog::revlog::{Revlog, RevlogError};
	use crate::revlog::Revision;			use crate::revlog::Revision;
	use crate::revlog::{Node, NodePrefix};			use crate::revlog::{Node, NodePrefix};
	use crate::utils::hg_path::HgPath;			use crate::utils::hg_path::HgPath;
	use crate::utils::SliceExt;			use crate::utils::SliceExt;
				use crate::vfs::Vfs;

	/// A specialized `Revlog` to work with `manifest` data format.			/// A specialized `Revlog` to work with `manifest` data format.
	pub struct Manifestlog {			pub struct Manifestlog {
	/// The generic `revlog` format.			/// The generic `revlog` format.
	revlog: Revlog,			revlog: Revlog,
	}			}

	impl Manifestlog {			impl Manifestlog {
	/// Open the `manifest` of a repository given by its root.			/// Open the `manifest` of a repository given by its root.
	pub fn open(repo: &Repo) -> Result<Self, HgError> {			pub fn open(store_vfs: &Vfs, use_nodemap: bool) -> Result<Self, HgError> {
	let use_nodemap = repo			let revlog =
	.requirements()			Revlog::open(store_vfs, "00manifest.i", None, use_nodemap)?;
	.contains(requirements::NODEMAP_REQUIREMENT);
	let revlog = Revlog::open(
	&repo.store_vfs(),
	"00manifest.i",
	None,
	use_nodemap,
	)?;
	Ok(Self { revlog })			Ok(Self { revlog })
	}			}

	/// Return the `Manifest` for the given node ID.			/// Return the `Manifest` for the given node ID.
	///			///
	/// Note: this is a node ID in the manifestlog, typically found through			/// Note: this is a node ID in the manifestlog, typically found through
	/// `ChangelogEntry::manifest_node`. It is not the node ID of any			/// `ChangelogEntry::manifest_node`. It is not the node ID of any
	/// changeset.			/// changeset.

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33184			Fri, Apr 15, 12:52 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

rust-revlog: make `Changelog` and `ManifestLog` unaware of `Repo`Needs ReviewPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33184

rust/hg-core/src/repo.rs

rust/hg-core/src/revlog/changelog.rs

rust/hg-core/src/revlog/manifest.rs

rust-revlog: make `Changelog` and `ManifestLog` unaware of `Repo`
Needs ReviewPublic

Revision Contents
Changeset List