This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1509

sparse: make use of treemanifest for far faster path listing
AbandonedPublic

Authored by mjpieters on Nov 24 2017, 11:35 AM.
Tags
None
Subscribers
durham

Details

Reviewers
durham
Group Reviewers
Restricted Project

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mjpieters created this revision.Nov 24 2017, 11:35 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2017, 11:35 AM
durham accepted this revision.Nov 28 2017, 7:20 PM
durham added a subscriber: durham.

Maybe add a test for this? You could add a test-treemanifest-sparse.tm. test-treemanifest-blame.t is a minimal test case you could copy to get started.

This revision is now accepted and ready to land.Nov 28 2017, 7:20 PM
mjpieters abandoned this revision.Oct 16 2018, 10:51 AM

Revision Contents
Changeset List

PathPackages
Mhgext3rd/fbsparse.py (25 lines)

Diff 3816

hgext3rd/fbsparse.py

cwd = util.normpath(os.getcwd()) cwd = util.normpath(os.getcwd())
cwd = os.path.relpath(cwd, root) cwd = os.path.relpath(cwd, root)
cwd = '' if cwd == os.curdir else cwd + os.sep cwd = '' if cwd == os.curdir else cwd + os.sep
if cwd.startswith(os.pardir + os.sep): if cwd.startswith(os.pardir + os.sep):
raise error.Abort( raise error.Abort(
_("the current working directory should begin " _("the current working directory should begin "
"with the root %s") % root) "with the root %s") % root)
tmf = None
if util.safehasattr(mf, '_treemanifest'):
# Hybrid manifest, use the (much) faster subtree support
tmf = mf._treemanifest()
if tmf is not None:
# a treemanifest is available for this revision
matcher = matchmod.match(
repo.root, repo.getcwd(),
patterns=['path:' + cwd])
files = tmf.matches(matcher)
else:
files = (f for f in mf if f.startswith(cwd))
sparsematch = repo.sparsematch(ctx.rev()) sparsematch = repo.sparsematch(ctx.rev())
checkedoutentries = set() checkedoutentries = set()
allentries = set() allentries = set()
cwdlength = len(cwd) cwdlength = len(cwd)
for filepath in mf: for filepath in files:
if filepath.startswith(cwd):
entryname = filepath[cwdlength:].partition(os.sep)[0] entryname = filepath[cwdlength:].partition(os.sep)[0]
allentries.add(entryname) allentries.add(entryname)
if sparsematch(filepath): if sparsematch(filepath):
checkedoutentries.add(entryname) checkedoutentries.add(entryname)
ui = repo.ui ui = repo.ui
for entry in sorted(allentries): for entry in sorted(allentries):
marker = ' ' if entry in checkedoutentries else '-' marker = ' ' if entry in checkedoutentries else '-'
ui.status("%s %s\n" % (marker, entry)) ui.status("%s %s\n" % (marker, entry))
class forceincludematcher(object): class forceincludematcher(object):
"""A matcher that returns true for any of the forced includes before testing """A matcher that returns true for any of the forced includes before testing