extutil: move flock to extutil
ClosedPublic

Authored by durham on Nov 30 2017, 6:32 PM.

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGX0eb3df0e50c0: extutil: move flock to extutil
Summary

We want to use this from multiple extensions so let's move it.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
durham created this revision.Nov 30 2017, 6:32 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2017, 6:32 PM
quark added a subscriber: quark.Nov 30 2017, 6:38 PM
quark added inline comments.
hgext3rd/extutil.py
206

This is using flock() instead of fcntl() libc function/syscall (the Python module name "fcntl" is just confusing - flock() has nothing to do with fcntl). The comment needs to be updated to use flock.

quark accepted this revision.Nov 30 2017, 6:38 PM
This revision is now accepted and ready to land.Nov 30 2017, 6:38 PM
This revision was automatically updated to reflect the committed changes.