This is an archive of the discontinued Mercurial Phabricator instance.

remotenames: rename related file and storage dir to logexchange
ClosedPublic

Authored by pulkit on Dec 6 2017, 1:57 PM.

Details

Summary

This patch renames remotenames.py to logexchange.py, test-remotenames.t to
test-logexchange.t. Also this patch renames the directory in which the data is
stored from remotenames to logexchange. After this patch, data about bookmarks
and branches from a server we pull is stored in
.hg/logexchange/(bookmarks|branches) files.

Thanks to smf for the suggestion.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Dec 6 2017, 1:57 PM
pulkit added a subscriber: smf.Dec 6 2017, 2:11 PM
pulkit added a subscriber: durin42.Dec 6 2017, 2:22 PM

Can you also rename the file stored by logexchange so it doesn't conflict with the out-of-tree extension?

Thanks!

pulkit edited the summary of this revision. (Show Details)Dec 6 2017, 5:50 PM
pulkit retitled this revision from remotenames: rename the file to logexchange to remotenames: rename related file and storage dir to logexchange.
pulkit updated this revision to Diff 4162.
smf added a comment.Dec 8 2017, 3:08 AM

pulkit (Pulkit Goyal) <phabricator@mercurial-scm.org> writes:

pulkit updated this revision to Diff 4162.
pulkit edited the summary of this revision.
pulkit retitled this revision from "remotenames: rename the file to logexchange" to "remotenames: rename related file and storage dir to logexchange".

This is better than before. Though, I'm still opposed to skipping hgext/.

krbullock requested changes to this revision.Dec 8 2017, 11:33 PM
krbullock added a subscriber: krbullock.

This doesn't apply cleanly. Can you rebase?

This revision now requires changes to proceed.Dec 8 2017, 11:33 PM
pulkit updated this revision to Diff 4289.Dec 9 2017, 2:32 PM
This revision was automatically updated to reflect the committed changes.