( )⚙ D1656 synthrepo: create filectx instance in 'filectxfn' callback

This is an archive of the discontinued Mercurial Phabricator instance.

synthrepo: create filectx instance in 'filectxfn' callback
ClosedPublic

Authored by martinvonz on Dec 11 2017, 12:47 PM.

Details

Summary

I would like to pass the memctx to the memfilectx constructor, but
it's not available where we currently create the memfilectx. It is
available in the 'filectxfn' callback, so let's create the memfilectx
there instead. A later patch will start actually passing the memctx.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Dec 11 2017, 12:47 PM
durin42 accepted this revision.Dec 11 2017, 1:14 PM
This revision is now accepted and ready to land.Dec 11 2017, 1:14 PM
martinvonz updated this revision to Diff 4364.Dec 11 2017, 3:33 PM
yuja requested changes to this revision.Dec 12 2017, 8:35 AM
yuja added a subscriber: yuja.
yuja added inline comments.
contrib/synthrepo.py
453

Perhaps filectxfn() should return None in this case.

This revision now requires changes to proceed.Dec 12 2017, 8:35 AM
martinvonz updated this revision to Diff 4380.Dec 12 2017, 2:34 PM
martinvonz marked an inline comment as done.Dec 12 2017, 2:34 PM
martinvonz added inline comments.
contrib/synthrepo.py
453

Oops, good catch.

martinvonz marked an inline comment as done.Dec 12 2017, 5:15 PM
This revision was automatically updated to reflect the committed changes.

Crud. I had an old version of this queued, and failed to drop it. Fixing now...

martinvonz updated this revision to Diff 4392.Dec 12 2017, 5:18 PM