This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1699

tests: avoid echo with backslash escapes
ClosedPublic

Authored by martinvonz on Dec 15 2017, 1:57 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG417fa23017f9: tests: avoid echo with backslash escapes
Summary

Some shells' echo (e.g. Bash's) do not interpret backslash escapes by
default, while others shells' do (e.g. Dash's). This led to a failure
in test-run-tests.t. We could switch to the more compatible printf,
but using a heredoc seems simpler, so that's what this patch does.

For anyone who wants to test this for themselves, remove the "unset
HGTEST_SHELL" line in helper-runtests.sh and pass
e.g. "--shell=/bin/dash" to the test runner.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Dec 15 2017, 1:57 AM
yuja accepted this revision.Dec 15 2017, 8:20 AM
This revision is now accepted and ready to land.Dec 15 2017, 8:20 AM
Closed by commit rHG417fa23017f9: tests: avoid echo with backslash escapes (authored by martinvonz). · Explain WhyDec 15 2017, 8:52 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-run-tests.t (14 lines)

Diff 4472

tests/test-run-tests.t

!. !.
Failed test-failure.t: output changed Failed test-failure.t: output changed
# Ran 2 tests, 0 skipped, 1 failed. # Ran 2 tests, 0 skipped, 1 failed.
python hash seed: * (glob) python hash seed: * (glob)
[1] [1]
Accept the fix Accept the fix
$ echo " $ echo 'saved backup bundle to \$TESTTMP/foo.hg'" >> test-failure.t $ cat >> test-failure.t <<EOF
$ echo " saved backup bundle to \$TESTTMP/foo.hg" >> test-failure.t > $ echo 'saved backup bundle to \$TESTTMP/foo.hg'
$ echo " $ echo 'saved backup bundle to \$TESTTMP/foo.hg'" >> test-failure.t > saved backup bundle to \$TESTTMP/foo.hg
$ echo " saved backup bundle to \$TESTTMP\\foo.hg" >> test-failure.t > $ echo 'saved backup bundle to \$TESTTMP/foo.hg'
$ echo " $ echo 'saved backup bundle to \$TESTTMP/foo.hg'" >> test-failure.t > saved backup bundle to $TESTTMP\\foo.hg
$ echo " saved backup bundle to \$TESTTMP/*.hg (glob)" >> test-failure.t > $ echo 'saved backup bundle to \$TESTTMP/foo.hg'
> saved backup bundle to \$TESTTMP/*.hg (glob)
> EOF
$ echo 'y' | rt -i 2>&1 $ echo 'y' | rt -i 2>&1
--- $TESTTMP/test-failure.t --- $TESTTMP/test-failure.t
+++ $TESTTMP/test-failure.t.err +++ $TESTTMP/test-failure.t.err
@@ -1,5 +1,5 @@ @@ -1,5 +1,5 @@
$ echo babar $ echo babar
- rataxes - rataxes
+ babar + babar