This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1701

logtoprocess: add the possibility to not popup a console
Needs RevisionPublic

Authored by lothiraldan on Dec 15 2017, 5:11 AM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers
Summary

Starting a subprocess on Windows with `DETACHED_PROCESS |
CREATE_NEW_PROCESS_GROUP` as startup info means starting a console GUI window
in almost all cases. If we add a logtoprocess for commandfinish and the prompt
do some hg calls, it will create a short-lived GUI window which is annoying
for end-users.

Creating a subprocess with CREATE_CONSOLE instead seems to no start a
console window but could have other side-effects so it kept under a config
knob.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Dec 15 2017, 5:11 AM
yuja added a subscriber: yuja.Dec 15 2017, 9:01 AM

but could have other side-effects so it kept under a config knob.

My two cents, experimental.* might be better if the config knob exists as
a workaround for an unknown bug.

hgext/logtoprocess.py
66

Can we add CREATE_NEW_PROCESS_GROUP ?

baymax requested changes to this revision.Jan 24 2020, 12:32 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:32 PM

Revision Contents
Changeset List

Diff 4468

hgext/logtoprocess.py

if pycompat.iswindows: if pycompat.iswindows:
# no fork on Windows, but we can create a detached process # no fork on Windows, but we can create a detached process
# https://msdn.microsoft.com/en-us/library/windows/desktop/ms684863.aspx # https://msdn.microsoft.com/en-us/library/windows/desktop/ms684863.aspx
# No stdlib constant exists for this value # No stdlib constant exists for this value
DETACHED_PROCESS = 0x00000008 DETACHED_PROCESS = 0x00000008
_creationflags = DETACHED_PROCESS | subprocess.CREATE_NEW_PROCESS_GROUP _creationflags = DETACHED_PROCESS | subprocess.CREATE_NEW_PROCESS_GROUP
def runshellcommand(script, env, ui): def runshellcommand(script, env, ui):
createconsole = ui.configbool("logtoprocess", "windows-create-console")
if createconsole:
creationflags = subprocess.CREATE_NEW_CONSOLE
yujaUnsubmitted
Not Done

Can we add CREATE_NEW_PROCESS_GROUP ?

yuja: Can we add `CREATE_NEW_PROCESS_GROUP` ?
else:
creationflags = _creationflags
# we can't use close_fds *and* redirect stdin. I'm not sure that we # we can't use close_fds *and* redirect stdin. I'm not sure that we
# need to because the detached process has no console connection. # need to because the detached process has no console connection.
subprocess.Popen( subprocess.Popen(
script, shell=True, env=env, close_fds=True, script, shell=True, env=env, close_fds=True,
creationflags=_creationflags) creationflags=creationflags)
else: else:
def runshellcommand(script, env, ui): def runshellcommand(script, env, ui):
# double-fork to completely detach from the parent process # double-fork to completely detach from the parent process
# based on http://code.activestate.com/recipes/278731 # based on http://code.activestate.com/recipes/278731
pid = os.fork() pid = os.fork()
if pid: if pid:
# parent # parent
return return

mercurial/configitems.py

default=None, default=None,
) )
coreconfigitem('logtoprocess', 'develwarn', coreconfigitem('logtoprocess', 'develwarn',
default=None, default=None,
) )
coreconfigitem('logtoprocess', 'uiblocked', coreconfigitem('logtoprocess', 'uiblocked',
default=None, default=None,
) )
coreconfigitem('logtoprocess', 'windows-create-console',
default=False,
)
coreconfigitem('merge', 'checkunknown', coreconfigitem('merge', 'checkunknown',
default='abort', default='abort',
) )
coreconfigitem('merge', 'checkignored', coreconfigitem('merge', 'checkignored',
default='abort', default='abort',
) )
coreconfigitem('experimental', 'merge.checkpathconflicts', coreconfigitem('experimental', 'merge.checkpathconflicts',
default=False, default=False,