This is an archive of the discontinued Mercurial Phabricator instance.

obsolete: use native string when peeking in __dict__
ClosedPublic

Authored by durin42 on Jan 18 2018, 8:38 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 18 2018, 8:38 AM
durin42 edited the summary of this revision. (Show Details)Jan 18 2018, 1:37 PM
pulkit added a subscriber: pulkit.Jan 19 2018, 1:22 AM

The commit description says "skip blame just a bytes prefix", I think that's not correct.

durin42 edited the summary of this revision. (Show Details)Jan 19 2018, 3:12 PM
pulkit accepted this revision.Jan 20 2018, 5:18 AM
indygreg accepted this revision.Feb 1 2018, 3:37 PM
indygreg added a subscriber: indygreg.

Using raw strings away from the consumer is a bit weird. But this is a minor nit.

This revision is now accepted and ready to land.Feb 1 2018, 3:37 PM
This revision was automatically updated to reflect the committed changes.