This is an archive of the discontinued Mercurial Phabricator instance.

Differential D193

fastlog: show all hg log output even if fastlog request failed
ClosedPublic

Authored by stash on Jul 28 2017, 6:14 AM.

Details

Reviewers
simonfar
Group Reviewers
Restricted Project
Commits
rFBHGX673fed9adeff: fastlog: show all hg log output even if fastlog request failed
Summary

We had a few troubles where fastlog failed with a weird error and people got
incorrect log output. While I still don't know why fastlog failed in the first
place, I've found the reason why log output was truncated. And this diff fixes
it. See the comments in the code for details.

Test Plan

Run unit-test

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

stash created this revision.Jul 28 2017, 6:14 AM
simonfar accepted this revision.Jul 28 2017, 6:51 AM
simonfar added a subscriber: simonfar.

Nice fix and comment!

hgext3rd/fastlog.py
489–500

You could simplify the comment a bit, to increase the chances of the reader not skipping over it:

# The end marker (self.id, True, None) indicates that the thread
# completed successfully. Don't send it if the thread is stopped.
# The thread can be stopped for one of two reasons:
#  1. The fastlog service failed - in this case, flagging a successful
#     finish is harmful, because it will stop us continuing with local
#     results, truncating output.
#  2. The caller is going to ignore all future results from us. In this
#     case, it'll ignore the end marker anyway - it's discarding the
#     entire queue.
This revision is now accepted and ready to land.Jul 28 2017, 6:51 AM
stash updated this revision to Diff 449.Jul 31 2017, 3:57 AM

Addressed comments

Closed by commit rFBHGX673fed9adeff: fastlog: show all hg log output even if fastlog request failed (authored by stash). · Explain WhyJul 31 2017, 1:00 PM
This revision was automatically updated to reflect the committed changes.
DavinBode added a subscriber: DavinBode.EditedJan 9 2022, 3:26 PM

It is very good thinking by the programmer to start separate email support service center and take directly their customers complaints before it is very hectic process where we should register our complaints in https://www.resumehelpservices.com/resumewriterdirect-review/ blog and then it will be transferred to the customer support team.

ThomasKenny added a subscriber: ThomasKenny.Jan 23 2022, 4:57 AM

Hey, this page is relevant to the search query! The user has found the information they were looking for!”

Dofollow Niche blog commenting

DayanaBecker added a subscriber: DayanaBecker.Fri, May 20, 12:04 PM

This is the information that I have been searching for on ai website landing page text generator blogs for the last few weeks. It is a good practice to do the code on your own and test it in the end. We can able to sort out the bugs.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/fastlog.py (13 lines)
Mtests/test-fastlog.t (18 lines)

Diff 454

hgext3rd/fastlog.py

revs = smartset.addset(revs, gen, ascending=False) revs = smartset.addset(revs, gen, ascending=False)
else: else:
revs = gen revs = gen
for rev in revs: for rev in revs:
if self.stopped(): if self.stopped():
break break
self.queue.put((self.id, True, rev)) self.queue.put((self.id, True, rev))
# The end marker (self.id, True, None) indicates that the thread
# completed successfully. Don't send it if the thread is stopped.
# The thread can be stopped for one of two reasons:
# 1. The fastlog service failed - in this case, flagging a successful
# finish is harmful, because it will stop us continuing with local
# results, truncating output.
# 2. The caller is going to ignore all future results from us. In this
# case, it'll ignore the end marker anyway - it's discarding the
# entire queue.
if not self.stopped():
self.queue.put((self.id, True, None)) self.queue.put((self.id, True, None))
simonfarUnsubmitted
Not Done

You could simplify the comment a bit, to increase the chances of the reader not skipping over it:

# The end marker (self.id, True, None) indicates that the thread
# completed successfully. Don't send it if the thread is stopped.
# The thread can be stopped for one of two reasons:
#  1. The fastlog service failed - in this case, flagging a successful
#     finish is harmful, because it will stop us continuing with local
#     results, truncating output.
#  2. The caller is going to ignore all future results from us. In this
#     case, it'll ignore the end marker anyway - it's discarding the
#     entire queue.
simonfar: You could simplify the comment a bit, to increase the chances of the reader not skipping over…
if __name__ == '__main__': if __name__ == '__main__':
import doctest import doctest
doctest.testmod() doctest.testmod()

tests/test-fastlog.t

Multi-path queries Multi-path queries
$ hg log parent/dir parent/dir2 -T '{node}\n' $ hg log parent/dir parent/dir2 -T '{node}\n'
11c9870ffc4024fab11bf166a00b2852ea36bcf6 11c9870ffc4024fab11bf166a00b2852ea36bcf6
5946a2427fdfcb068a8aec1a59227d0d76062b43 5946a2427fdfcb068a8aec1a59227d0d76062b43
728676e01661ccc3d7e39de054ca3a7288d7e7b6 728676e01661ccc3d7e39de054ca3a7288d7e7b6
Test with failed network call
$ cat > $TESTTMP/bad_conduit.py <<'EOF'
> def call_conduit(*args, **kwargs):
> raise Exception('failed')
> def conduit_config(*args, **kwargs):
> return True
> EOF
$ cat >> $HGRCPATH << EOF
> [extensions]
> fbconduit=$TESTTMP/bad_conduit.py
> EOF
$ hg log parent -T '{rev} {desc}\n' 2>&1 | grep --invert-match 'failed'
9 toys
8 treats
7 cookies
6 major repo reorg