This is an archive of the discontinued Mercurial Phabricator instance.

pathencode: allow clang-format oversight
ClosedPublic

Authored by durin42 on Feb 12 2018, 10:44 AM.

Details

Summary

Only had to add two trailing commas to make the file format acceptably!

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 12 2018, 10:44 AM
indygreg accepted this revision.Feb 12 2018, 2:15 PM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
mercurial/cext/pathencode.c
129–131

I actually prefer the old style. But the good thing about using clang-format is we can bikeshed on the style later and mass rewrite things after that debate has concluded with minimal effort. So getting things to clang format is the important goal here, not bikeshedding about the style it is using today.

283–284

/me screams

This revision is now accepted and ready to land.Feb 12 2018, 2:15 PM
This revision was automatically updated to reflect the committed changes.