This is an archive of the discontinued Mercurial Phabricator instance.

py3: introduce and use pycompat.getargspec
ClosedPublic

Authored by durin42 on Feb 14 2018, 12:35 AM.

Details

Summary

This is getfullargspec on py3, which means we can't use namedtuple
named accessors for all fields (eg keywords from getargspec is varkw
from getfullargspec, with the same meaning). Solves some warning
issues on Python 3.

I didn't clean up httpclient because that's vendored code I think we
should probably discard, and I didn't touch the manpage generator for
now either.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 14 2018, 12:35 AM
indygreg accepted this revision.Feb 14 2018, 12:59 AM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
contrib/perf.py
43

This looks like a double space. I'll fix this in flight.

This revision is now accepted and ready to land.Feb 14 2018, 12:59 AM
This revision was automatically updated to reflect the committed changes.