( )⚙ D2381 tests: store protocol payload in files

This is an archive of the discontinued Mercurial Phabricator instance.

tests: store protocol payload in files
ClosedPublic

Authored by indygreg on Feb 21 2018, 5:08 PM.

Details

Summary

Upcoming changes to version 2 of the SSH protocol will introduce
binary components to the protocol. It will be easier to eliminate
trailing newlines and use binary in the tests if the protocol
payload is being generated by Python.

So use inline Python to write payloads to files and pipe those files
to server processes instead of shell strings/variables.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 21 2018, 5:08 PM
yuja accepted this revision.Feb 22 2018, 9:05 AM
This revision is now accepted and ready to land.Feb 22 2018, 9:05 AM
This revision was automatically updated to reflect the committed changes.