( )⚙ D241 context: rename bumped into phasedivergent

This is an archive of the discontinued Mercurial Phabricator instance.

context: rename bumped into phasedivergent
ClosedPublic

Authored by lothiraldan on Aug 7 2017, 6:08 AM.

Details

Summary

Rename bumped context method into phasedivergent and add a deprecation warning
on bumped.

Only update all callers to keep the patch straightforward.

The renaming is done according to
https://www.mercurial-scm.org/wiki/CEDVocabulary.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Aug 7 2017, 6:08 AM
indygreg requested changes to this revision.Aug 8 2017, 12:39 AM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
mercurial/context.py
220

Shouldn't this be self.phasedivergent()?

This revision now requires changes to proceed.Aug 8 2017, 12:39 AM
lothiraldan added inline comments.Aug 8 2017, 5:09 AM
mercurial/context.py
220

Yes definitely, thanks for the catch

lothiraldan edited edge metadata.Aug 8 2017, 5:33 AM
lothiraldan updated this revision to Diff 622.
lothiraldan marked 2 inline comments as done.Aug 8 2017, 5:36 AM
This revision was automatically updated to reflect the committed changes.