This is an archive of the discontinued Mercurial Phabricator instance.

obsmarker: rename precnode into prednode
ClosedPublic

Authored by lothiraldan on Aug 7 2017, 6:08 AM.

Details

Summary

Rename prednode (predecessors node) into precnode (precursors node) in markers
class. Use util.nouideprecwarn because markers doesn't have easy access to an
ui object.

The renaming is done according to
https://www.mercurial-scm.org/wiki/CEDVocabulary.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Aug 7 2017, 6:08 AM
dsp accepted this revision.Aug 8 2017, 11:52 AM
This revision was automatically updated to reflect the committed changes.
lothiraldan updated this revision to Diff 705.Aug 9 2017, 1:19 PM
yuja added a subscriber: yuja.Aug 13 2017, 1:05 AM
yuja added inline comments.
mercurial/cmdutil.py
1916

The template keyword should be updated as well. Please send a follow-up.

lothiraldan added inline comments.Aug 14 2017, 5:24 AM
mercurial/cmdutil.py
1916

I'm not sure to see which template keyword you are talking about.

yuja added inline comments.Aug 14 2017, 9:15 PM
mercurial/cmdutil.py
1916

fm.write('prednode', ...)

lothiraldan marked 3 inline comments as done.Aug 16 2017, 4:29 AM
lothiraldan added inline comments.
mercurial/cmdutil.py
1916