This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2708

rebase: delete obsolete internal "keepopen" option
ClosedPublic

Authored by martinvonz on Mar 7 2018, 1:23 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGf7e3fe95b663: rebase: delete obsolete internal "keepopen" option
Summary

The option was apparently introduced for use by the "pbranch"
extension, see f2558a8228be (rebase: add option to not commit after a
collapsing, 2010-02-07). However, it doesn't seem like it was ever
used by that extension (according to hg grep in a clone of
https://bitbucket.org/parren/hg-pbranch/), so let's delete it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 7 2018, 1:23 PM
martinvonz edited the summary of this revision. (Show Details)Mar 7 2018, 1:32 PM
indygreg accepted this revision.Mar 7 2018, 4:12 PM
This revision is now accepted and ready to land.Mar 7 2018, 4:12 PM
Closed by commit rHGf7e3fe95b663: rebase: delete obsolete internal "keepopen" option (authored by martinvonz). · Explain WhyMar 7 2018, 4:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/rebase.py (5 lines)

Diff 6703

hgext/rebase.py

e = opts.get('extrafn') # internal, used by e.g. hgsubversion e = opts.get('extrafn') # internal, used by e.g. hgsubversion
self.extrafns = [_savegraft] self.extrafns = [_savegraft]
if e: if e:
self.extrafns = [e] self.extrafns = [e]
self.keepf = opts.get('keep', False) self.keepf = opts.get('keep', False)
self.keepbranchesf = opts.get('keepbranches', False) self.keepbranchesf = opts.get('keepbranches', False)
# keepopen is not meant for use on the command line, but by
# other extensions
self.keepopen = opts.get('keepopen', False)
self.obsoletenotrebased = {} self.obsoletenotrebased = {}
self.obsoletewithoutsuccessorindestination = set() self.obsoletewithoutsuccessorindestination = set()
self.inmemory = inmemory self.inmemory = inmemory
@property @property
def repo(self): def repo(self):
if self.prepared: if self.prepared:
return self._repo.unfiltered() return self._repo.unfiltered()
ui.status(_('already rebased %s as %s\n') % ui.status(_('already rebased %s as %s\n') %
(desc, repo[self.state[rev]])) (desc, repo[self.state[rev]]))
return pos return pos
def _finishrebase(self): def _finishrebase(self):
repo, ui, opts = self.repo, self.ui, self.opts repo, ui, opts = self.repo, self.ui, self.opts
fm = ui.formatter('rebase', opts) fm = ui.formatter('rebase', opts)
fm.startitem() fm.startitem()
if self.collapsef and not self.keepopen: if self.collapsef:
p1, p2, _base = defineparents(repo, min(self.state), self.destmap, p1, p2, _base = defineparents(repo, min(self.state), self.destmap,
self.state, self.skipped, self.state, self.skipped,
self.obsoletenotrebased) self.obsoletenotrebased)
editopt = opts.get('edit') editopt = opts.get('edit')
editform = 'rebase.collapse' editform = 'rebase.collapse'
if self.collapsemsg: if self.collapsemsg:
commitmsg = self.collapsemsg commitmsg = self.collapsemsg
else: else: