I collapsed multiple assignments because they don't appear to
be necessary. We don't invoke the requestbuilder in anything
called during init. So there's no reason to not define it
earlier AFAICT.
This seemingly useless attribute is actually an extension point.
Document it as such.
(A previous version of this patch removed the attribute because
it appeared to just be an alias.)
| Lint Skipped |
| Unit Tests Skipped |
Looks like this was added so that extensions can replace using urllib2.Request. https://www.mercurial-scm.org/repo/hg/rev/00ecc894138d
In D2723#46187, @pulkit wrote:Looks like this was added so that extensions can replace using urllib2.Request. https://www.mercurial-scm.org/repo/hg/rev/00ecc894138d
Thanks for looking that up. We still depend on it, so we'd appreciate if it could stay. Perhaps we should have added comment saying that it was there for extensibility.
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/httppeer.py (5 lines) |
| f.seek(0) | f.seek(0) | ||||
| self._index = 0 | self._index = 0 | ||||
| class httppeer(wireproto.wirepeer): | class httppeer(wireproto.wirepeer): | ||||
| def __init__(self, ui, path): | def __init__(self, ui, path): | ||||
| self._path = path | self._path = path | ||||
| self._caps = None | self._caps = None | ||||
| self._urlopener = None | self._urlopener = None | ||||
| self._requestbuilder = None | # This is an its own attribute to facilitate extensions overriding | ||||
| # the default type. | |||||
| self._requestbuilder = urlreq.request | |||||
| u = util.url(path) | u = util.url(path) | ||||
| if u.query or u.fragment: | if u.query or u.fragment: | ||||
| raise error.Abort(_('unsupported URL component: "%s"') % | raise error.Abort(_('unsupported URL component: "%s"') % | ||||
| (u.query or u.fragment)) | (u.query or u.fragment)) | ||||
| # urllib cannot handle URLs with embedded user or passwd | # urllib cannot handle URLs with embedded user or passwd | ||||
| self._url, authinfo = u.authinfo() | self._url, authinfo = u.authinfo() | ||||
| self._ui = ui | self._ui = ui | ||||
| ui.debug('using %s\n' % self._url) | ui.debug('using %s\n' % self._url) | ||||
| self._urlopener = urlmod.opener(ui, authinfo) | self._urlopener = urlmod.opener(ui, authinfo) | ||||
| self._requestbuilder = urlreq.request | |||||
| def __del__(self): | def __del__(self): | ||||
| urlopener = getattr(self, '_urlopener', None) | urlopener = getattr(self, '_urlopener', None) | ||||
| if urlopener: | if urlopener: | ||||
| for h in urlopener.handlers: | for h in urlopener.handlers: | ||||
| h.close() | h.close() | ||||
| getattr(h, "close_all", lambda: None)() | getattr(h, "close_all", lambda: None)() | ||||