diff --git a/mercurial/hgweb/common.py b/mercurial/hgweb/common.py --- a/mercurial/hgweb/common.py +++ b/mercurial/hgweb/common.py @@ -214,12 +214,6 @@ config("ui", "username") or encoding.environ.get("EMAIL") or "") -def caching(web, req): - tag = r'W/"%d"' % web.mtime - if req.env.get('HTTP_IF_NONE_MATCH') == tag: - raise ErrorResponse(HTTP_NOT_MODIFIED) - req.headers.append(('ETag', tag)) - def cspvalues(ui): """Obtain the Content-Security-Policy header and nonce value. diff --git a/mercurial/hgweb/hgweb_mod.py b/mercurial/hgweb/hgweb_mod.py --- a/mercurial/hgweb/hgweb_mod.py +++ b/mercurial/hgweb/hgweb_mod.py @@ -18,7 +18,6 @@ HTTP_NOT_MODIFIED, HTTP_OK, HTTP_SERVER_ERROR, - caching, cspvalues, permhooks, ) @@ -388,7 +387,13 @@ # Don't enable caching if using a CSP nonce because then it wouldn't # be a nonce. if rctx.configbool('web', 'cache') and not rctx.nonce: - caching(self, wsgireq) # sets ETag header or raises NOT_MODIFIED + tag = 'W/"%d"' % self.mtime + if req.headers.get('If-None-Match') == tag: + raise ErrorResponse(HTTP_NOT_MODIFIED) + + wsgireq.headers.append((r'ETag', pycompat.sysstr(tag))) + res.headers['ETag'] = tag + if cmd not in webcommands.__all__: msg = 'no such method: %s' % cmd raise ErrorResponse(HTTP_BAD_REQUEST, msg)