This is an archive of the discontinued Mercurial Phabricator instance.

lz4wrapper: eagerly import lz4 extension modules
ClosedPublic

Authored by durin42 on Mar 19 2018, 4:38 PM.
Tags
None
Subscribers
None

Details

Reviewers
durham
Group Reviewers
Restricted Project
Commits
rFBHGXc093622bcfae: lz4wrapper: eagerly import lz4 extension modules
Summary

On Windows I was seeing some weirdness around finding RLock in the threading
module that originated here. I spent more time than I should have debugging,
but this fixes the problem and lets me at least load remotefilelog properly
on Windows. If it matters, this was Python from python.org, version 2.7.14.

Some of this demandimport disable goo was cargo-culted from the in-core
highlight extension. We should probably look into globally ignorning
some of the pkg_resources and friends.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Mar 19 2018, 4:38 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 19 2018, 4:38 PM
durham accepted this revision.Mar 19 2018, 5:47 PM
This revision is now accepted and ready to land.Mar 19 2018, 5:47 PM
This revision was automatically updated to reflect the committed changes.