This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3004

stringutil: edit comment to reflect actual data type name
ClosedPublic

Authored by sheehan on Mar 31 2018, 4:37 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG2ed180117f76: stringutil: edit comment to reflect actual data type name
Summary

In development the data type used to hold an email/name pair
was called a "mailmaptup" since it was implemented as a
namedtuple. The implementation has since been changed to use
an @attr.s decorated class named mailmapping. This commit
changes a comment to reflect this change.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sheehan created this revision.Mar 31 2018, 4:37 PM
yuja accepted this revision.Mar 31 2018, 9:27 PM
This revision is now accepted and ready to land.Mar 31 2018, 9:27 PM
Closed by commit rHG2ed180117f76: stringutil: edit comment to reflect actual data type name (authored by sheehan). · Explain WhyMar 31 2018, 9:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/utils/stringutil.py (2 lines)

Diff 7483

mercurial/utils/stringutil.py

>>> mapname(m, b'Unknown Name <unknown@email.com>') >>> mapname(m, b'Unknown Name <unknown@email.com>')
'Unknown Name <unknown@email.com>' 'Unknown Name <unknown@email.com>'
""" """
# If the author field coming in isn't in the correct format, # If the author field coming in isn't in the correct format,
# or the mailmap is empty just return the original author field # or the mailmap is empty just return the original author field
if not isauthorwellformed(author) or not mailmap: if not isauthorwellformed(author) or not mailmap:
return author return author
# Turn the user name into a mailmaptup # Turn the user name into a mailmapping
commit = mailmapping(name=person(author), email=email(author)) commit = mailmapping(name=person(author), email=email(author))
try: try:
# Try and use both the commit email and name as the key # Try and use both the commit email and name as the key
proper = mailmap[commit] proper = mailmap[commit]
except KeyError: except KeyError:
# If the lookup fails, use just the email as the key instead # If the lookup fails, use just the email as the key instead