( )⚙ D3191 clone: avoid using repo.lookup() with binary nodeid

This is an archive of the discontinued Mercurial Phabricator instance.

clone: avoid using repo.lookup() with binary nodeid
ClosedPublic

Authored by martinvonz on Apr 8 2018, 12:46 PM.

Details

Summary

The code in hg.clone() is a bit of a mess, but it seems like the
"checkout" variable is always a binary nodeid (tests pass when run
with "assert len(checkout) == 20" before the
repo.lookup()). repo.lookup() will soon work only with string inputs,
so we need remove this use.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 8 2018, 12:46 PM
This revision was automatically updated to reflect the committed changes.