( )⚙ D3230 wireproto: extract HTTP version 2 code to own module

This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: extract HTTP version 2 code to own module
ClosedPublic

Authored by indygreg on Apr 10 2018, 9:28 PM.

Details

Summary

wireprotoserver has generic and version 1 server code. The wireproto
module also has both version 1 and version 2 command implementations.
Upcoming work I want to do will make it difficult for this code to
live in the current locations. Plus, it kind of makes sense for the
version 2 code to live in an isolated module.

This commit copies the HTTPv2 bits from wireprotoserver into a new
module. We do it as a file copy to preserve history. A future
commit will be copying wire protocol commands into this module
as well. But there is little history of that code, so it makes
sense to take history for wireprotoserver.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 10 2018, 9:28 PM
durin42 added inline comments.
mercurial/httppeer.py
507–508

nit: should we (as a cleanup step) rename this to something that doesn't sound like it means RFC7540?

durin42 accepted this revision.Apr 11 2018, 12:36 PM
This revision is now accepted and ready to land.Apr 11 2018, 12:36 PM
This revision was automatically updated to reflect the committed changes.