This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3389

context: clarify deprecation warning message
ClosedPublic

Authored by martinvonz on Apr 16 2018, 12:40 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG6e137da59ad9: context: clarify deprecation warning message
Summary

I had one developer report that they couldn't find the message. This
patch should make it clear where to find it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 16 2018, 12:40 PM
durin42 accepted this revision.Apr 16 2018, 6:59 PM
This revision is now accepted and ready to land.Apr 16 2018, 6:59 PM
Closed by commit rHG6e137da59ad9: context: clarify deprecation warning message (authored by martinvonz). · Explain WhyApr 16 2018, 7:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (5 lines)

Diff 8332

mercurial/context.py

# use the appropriate mechanism for that namespace # use the appropriate mechanism for that namespace
# * If you know that "x" is a hex nodeid prefix, use # * If you know that "x" is a hex nodeid prefix, use
# repo[scmutil.resolvehexnodeidprefix(repo, x)] # repo[scmutil.resolvehexnodeidprefix(repo, x)]
# * If "x" is a string that can be any of the above, but you don't want # * If "x" is a string that can be any of the above, but you don't want
# to allow general revsets (perhaps because "x" may come from a remote # to allow general revsets (perhaps because "x" may come from a remote
# user and the revset may be too costly), use scmutil.revsymbol(repo, x) # user and the revset may be too costly), use scmutil.revsymbol(repo, x)
# * If "x" can be a mix of the above, you'll have to figure it out # * If "x" can be a mix of the above, you'll have to figure it out
# yourself # yourself
repo.ui.deprecwarn("changectx.__init__ is getting more limited, see source " repo.ui.deprecwarn("changectx.__init__ is getting more limited, see "
"for details", "4.6", stacklevel=4) "context.changectxdeprecwarn() for details", "4.6",
stacklevel=4)
class changectx(basectx): class changectx(basectx):
"""A changecontext object makes access to data related to a particular """A changecontext object makes access to data related to a particular
changeset convenient. It represents a read-only context already present in changeset convenient. It represents a read-only context already present in
the repo.""" the repo."""
def __init__(self, repo, changeid='.'): def __init__(self, repo, changeid='.'):
"""changeid is a revision number, node, or tag""" """changeid is a revision number, node, or tag"""
super(changectx, self).__init__(repo) super(changectx, self).__init__(repo)