This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	martinvonz	D3502 shortest: move revnum-disambiguation out of revlog
Closed	martinvonz	D3501 shortest: remove unnecessary check for revnum in isvalid()
Closed	martinvonz	D3500 shortest: make pure code also disambigute against revnums at end
Closed	martinvonz	D3499 revlog: use node tree (native code) for shortest() calculation
Closed	martinvonz	D3498 revlog: use literal -1 instead of variable that always has that value
Closed	martinvonz	D3497 revlog: extract function for fully populating the radix tree

Diff 8609

	rev = index_find_node(self, node, nodelen);			rev = index_find_node(self, node, nodelen);
	if (rev >= -1)			if (rev >= -1)
	return PyInt_FromLong(rev);			return PyInt_FromLong(rev);
	if (rev == -2)			if (rev == -2)
	raise_revlog_error();			raise_revlog_error();
	return NULL;			return NULL;
	}			}

	static int nt_partialmatch(indexObject self, const char node,			/*
	Py_ssize_t nodelen)			* Fully populate the radix tree.
	{			*/
				static int nt_populate(indexObject *self) {
	int rev;			int rev;

	if (nt_init(self) == -1)
	return -3;

	if (self->ntrev > 0) {			if (self->ntrev > 0) {
	/* ensure that the radix tree is fully populated */
	for (rev = self->ntrev - 1; rev >= 0; rev--) {			for (rev = self->ntrev - 1; rev >= 0; rev--) {
	const char *n = index_node_existing(self, rev);			const char *n = index_node_existing(self, rev);
	if (n == NULL)			if (n == NULL)
	return -3;			return -1;
	if (nt_insert(self, n, rev) == -1)			if (nt_insert(self, n, rev) == -1)
	return -3;			return -1;
	}			}
	self->ntrev = rev;			self->ntrev = rev;
	}			}
				return 0;
				}

				static int nt_partialmatch(indexObject self, const char node,
				Py_ssize_t nodelen)
				{
				if (nt_init(self) == -1)
				return -3;
				if (nt_populate(self) == -1)
				return -3;

	return nt_find(self, node, nodelen, 1);			return nt_find(self, node, nodelen, 1);
	}			}

	static PyObject index_partialmatch(indexObject self, PyObject *args)			static PyObject index_partialmatch(indexObject self, PyObject *args)
	{			{
	const char *fullnode;			const char *fullnode;
	int nodelen;			int nodelen;