( )⚙ D3501 shortest: remove unnecessary check for revnum in isvalid()

This is an archive of the discontinued Mercurial Phabricator instance.

shortest: remove unnecessary check for revnum in isvalid()
ClosedPublic

Authored by martinvonz on May 8 2018, 2:07 PM.

Details

Summary

We now always disambiguating against revnums after we've found an
otherwise valid prefix, so we can safely remove the early isrev()
check in isvalid().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.May 8 2018, 2:07 PM
This revision was automatically updated to reflect the committed changes.