This is an archive of the discontinued Mercurial Phabricator instance.

hg: Avoid relying on errno numbers / descriptions
ClosedPublic

Authored by mithrandi on Aug 12 2017, 8:33 AM.

Details

Summary

A few tests hardcode errno numbers and/or descriptions in the output, causing
test failures on platforms where these values are different.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mithrandi created this revision.Aug 12 2017, 8:33 AM

Sigh. Do you happen to know if the names of the errno enum values is constant? If it is, maybe we could turn the number back into a name.

In any case, queued for stable.

durin42 accepted this revision.Aug 15 2017, 1:11 PM
This revision is now accepted and ready to land.Aug 15 2017, 1:11 PM
In D362#6200, @durin42 wrote:

Sigh. Do you happen to know if the names of the errno enum values is constant? If it is, maybe we could turn the number back into a name.

As far as I know, the names are specified by POSIX so they should be constant, but I'm not 100% sure about that.

This revision was automatically updated to reflect the committed changes.