This is an archive of the discontinued Mercurial Phabricator instance.

undo: don't break when undo isn't first argument
ClosedPublic

Authored by felixmerk on Aug 14 2017, 10:29 PM.
Tags
None
Subscribers

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGX6908f308daeb: undo: don't break when undo isn't first argument
Summary

Undo commands where undo wasn't first, for example hg --pager=off undo break
multiple things, including hg redo. This change fixes this.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

felixmerk created this revision.Aug 14 2017, 10:29 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2017, 10:29 PM
quark accepted this revision.Aug 15 2017, 2:48 PM
quark added a subscriber: quark.
quark added inline comments.
hgext3rd/undo.py
687

Append , gnu=True here. fancyopts will ignore undo in commandlist automatically.

687–688

This might be fragile if there are aliases. I found a better solution.

This revision is now accepted and ready to land.Aug 15 2017, 2:48 PM
felixmerk updated this revision to Diff 965.Aug 15 2017, 7:54 PM
This revision was automatically updated to reflect the committed changes.