This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4144

changegroup: assign to proper attribute
ClosedPublic

Authored by indygreg on Aug 6 2018, 7:46 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG9134c4e46084: changegroup: assign to proper attribute
Summary

0548f696795b accidentally assigned to self.clrevtolocalrev instead of
self._clrevtolocalrev. Surprisingly, no tests failed as a result of
this mistake. Curious.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 6 2018, 7:46 PM
martinvonz accepted this revision.Aug 7 2018, 12:46 AM
This revision is now accepted and ready to land.Aug 7 2018, 12:46 AM
Closed by commit rHG9134c4e46084: changegroup: assign to proper attribute (authored by indygreg). · Explain WhyAug 7 2018, 12:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (2 lines)

Diff 10030

mercurial/changegroup.py

# Maps changelog nodes to changelog revs. Filled in once # Maps changelog nodes to changelog revs. Filled in once
# during changelog stage and then left unmodified. # during changelog stage and then left unmodified.
self._clnodetorev = {} self._clnodetorev = {}
def _close(self): def _close(self):
# Ellipses serving mode. # Ellipses serving mode.
self._clrevtolocalrev.clear() self._clrevtolocalrev.clear()
if self._nextclrevtolocalrev: if self._nextclrevtolocalrev:
self.clrevtolocalrev = self._nextclrevtolocalrev self._clrevtolocalrev = self._nextclrevtolocalrev
self._nextclrevtolocalrev.clear() self._nextclrevtolocalrev.clear()
self._changelogdone = True self._changelogdone = True
return closechunk() return closechunk()
def _fileheader(self, fname): def _fileheader(self, fname):
return chunkheader(len(fname)) + fname return chunkheader(len(fname)) + fname