This is an archive of the discontinued Mercurial Phabricator instance.

Differential D417

remotefilelog: flaky bgprefetch test fix
ClosedPublic

Authored by ms2316 on Aug 16 2017, 12:08 PM.
Tags
None
Subscribers
None

Details

Reviewers
ryanmce
simonfar
Group Reviewers
Restricted Project
Commits
rFBHGX5ca093c4ddcf: remotefilelog: flaky bgprefetch test fix
Summary

The test fails due to a race condition. Now the failing part of the test
output is optional.

Test Plan

Ensure that unit tests do not fail

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ms2316 created this revision.Aug 16 2017, 12:08 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 16 2017, 12:08 PM
ryanmce accepted this revision.Aug 16 2017, 12:14 PM
This revision is now accepted and ready to land.Aug 16 2017, 12:14 PM
Closed by commit rFBHGX5ca093c4ddcf: remotefilelog: flaky bgprefetch test fix (authored by ms2316). · Explain WhyAug 16 2017, 4:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1015

tests/test-remotefilelog-bgprefetch.t

z z
Node Delta Base Delta Length Node Delta Base Delta Length
69a1b6752270 000000000000 2 69a1b6752270 000000000000 2
# Check that foreground prefetch fetches revs specified by '. + draft() + bgprefetchrevs + pullprefetch' # Check that foreground prefetch fetches revs specified by '. + draft() + bgprefetchrevs + pullprefetch'
$ clearcache $ clearcache
$ hg prefetch --repack $ hg prefetch --repack
waiting for lock on prefetching in $TESTTMP/shallow held by process * on host * (glob) (?)
got lock after * seconds (glob) (?)
(running background incremental repack) (running background incremental repack)
5 files fetched over 1 fetches - (5 misses, 0.00% hit ratio) over *s (glob) * files fetched over 1 fetches - (* misses, 0.00% hit ratio) over *s (glob) (?)
$ sleep 0.5 $ sleep 0.5
$ hg debugwaitonrepack >/dev/null 2>%1 $ hg debugwaitonrepack >/dev/null 2>%1
$ find $CACHEDIR -type f | sort $ find $CACHEDIR -type f | sort
$TESTTMP/hgcache/master/packs/27c52c105a1ddf8c75143a6b279b04c24b1f4bee.histidx $TESTTMP/hgcache/master/packs/27c52c105a1ddf8c75143a6b279b04c24b1f4bee.histidx
$TESTTMP/hgcache/master/packs/27c52c105a1ddf8c75143a6b279b04c24b1f4bee.histpack $TESTTMP/hgcache/master/packs/27c52c105a1ddf8c75143a6b279b04c24b1f4bee.histpack
$TESTTMP/hgcache/master/packs/8299d5a1030f073f4adbb3b6bd2ad3bdcc276df0.dataidx $TESTTMP/hgcache/master/packs/8299d5a1030f073f4adbb3b6bd2ad3bdcc276df0.dataidx
$TESTTMP/hgcache/master/packs/8299d5a1030f073f4adbb3b6bd2ad3bdcc276df0.datapack $TESTTMP/hgcache/master/packs/8299d5a1030f073f4adbb3b6bd2ad3bdcc276df0.datapack