Page MenuHomePhabricator

fbamend: precursor -> predecessor
ClosedPublic

Authored by ryanmce on Aug 17 2017, 1:29 PM.

Details

Reviewers
simonfar
simpkins
Group Reviewers
Restricted Project
Commits
rFBHGXaf24a7fe2383: fbamend: precursor -> predecessor
Summary

Get in line with upstream name change and eliminate develwarns.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ryanmce created this revision.Aug 17 2017, 1:29 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2017, 1:29 PM
simonfar accepted this revision.Aug 17 2017, 3:19 PM
simonfar added a subscriber: simonfar.

Just nits, some of them probably old.

hgext3rd/fbamend/revsets.py
37–38

This comment looks wrong - but I think it might be right.

44–45

Can you reinsert the s in the function name?

50

This comment is wrong.

hgext3rd/fbamend/unamend.py
21–22

This looks odd, too.

This revision is now accepted and ready to land.Aug 17 2017, 3:19 PM
simpkins accepted this revision.Aug 17 2017, 6:46 PM
simpkins added a subscriber: simpkins.
simpkins added inline comments.
hgext3rd/fbamend/revsets.py
47

I believe it should work to just say

@revsetpredicate('precursors(set)')
@revsetpredicate('predecessors(set)')
def predecessors(repo, subset, x):
    # ...

The current code is fine too, though, if you prefer that.

quark added a subscriber: quark.Aug 17 2017, 7:37 PM
quark added inline comments.
hgext3rd/fbamend/revsets.py
37–45

This could be removed since the upstream has successors implemented (and is actually allsuccessors which is more useful).

ryanmce added inline comments.Aug 18 2017, 5:37 AM
hgext3rd/fbamend/revsets.py
37–45

Oh cool, I'll remove it then.

47

I'll give that a shot, it looks preferable to me.

50

I didn't actually change it apart from the search-replace; it was wrong originally but I guess I can fix it up since I'm here :-)

hgext3rd/fbamend/unamend.py
21–22

I agree.

ryanmce marked 6 inline comments as done.Aug 18 2017, 5:54 AM
ryanmce added inline comments.
hgext3rd/fbamend/revsets.py
44–45

I've deleted it per @quark

ryanmce marked 3 inline comments as done.Aug 18 2017, 6:05 AM
ryanmce updated this revision to Diff 1061.

per suggestions

This revision was automatically updated to reflect the committed changes.