This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4586

rfl: remove assignment to cg1packer
ClosedPublic

Authored by martinvonz on Sep 13 2018, 6:14 PM.
Tags
None
Subscribers
None

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rFBHGX3567ff51e382: rfl: remove assignment to cg1packer
Summary

The comment in the code says that it was there because some users in
core called changegroup.cg1packer directly (the packer map is updated
a little furhter down). AFAICT, the last caller was removed in
f85dfde1731a (changegroup: replace getsubset with makechangegroup,
2017-09-10).

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Sep 13 2018, 6:14 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2018, 6:14 PM
Closed by commit rFBHGX3567ff51e382: rfl: remove assignment to cg1packer (authored by martinvonz). · Explain WhySep 13 2018, 6:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mremotefilelog/__init__.py (3 lines)

Diff 11037

remotefilelog/__init__.py

clientonetime = False clientonetime = False
def onetimeclientsetup(ui): def onetimeclientsetup(ui):
global clientonetime global clientonetime
if clientonetime: if clientonetime:
return return
clientonetime = True clientonetime = True
# some users in core still call changegroup.cg1packer directly
changegroup.cg1packer = shallowbundle.shallowcg1packer
packermap = None packermap = None
if util.safehasattr(changegroup, 'packermap'): if util.safehasattr(changegroup, 'packermap'):
packermap = changegroup.packermap packermap = changegroup.packermap
elif util.safehasattr(changegroup, '_packermap'): elif util.safehasattr(changegroup, '_packermap'):
packermap = changegroup._packermap packermap = changegroup._packermap
# Partway through the hg 4.8 cycle all packers were consolidated # Partway through the hg 4.8 cycle all packers were consolidated
# down to just cgpacker and they were constructed using factory # down to just cgpacker and they were constructed using factory