This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4732

py3: use pycompat.strkwargs()
ClosedPublic

Authored by indygreg on Sep 24 2018, 11:32 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG3ed53b071041: py3: use pycompat.strkwargs()
Summary

Otherwise we get an error attempting to dispatch a command with
arguments because we're passing a dict with bytes keys.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 24 2018, 11:32 PM
Closed by commit rHG3ed53b071041: py3: use pycompat.strkwargs() (authored by indygreg). · Explain WhySep 25 2018, 9:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprotov2server.py (2 lines)

Diff 11346

mercurial/wireprotov2server.py

return repo.filtered('served') return repo.filtered('served')
def dispatch(repo, proto, command): def dispatch(repo, proto, command):
repo = getdispatchrepo(repo, proto, command) repo = getdispatchrepo(repo, proto, command)
func, spec = COMMANDS[command] func, spec = COMMANDS[command]
args = proto.getargs(spec) args = proto.getargs(spec)
return func(repo, proto, **args) return func(repo, proto, **pycompat.strkwargs(args))
@interfaceutil.implementer(wireprototypes.baseprotocolhandler) @interfaceutil.implementer(wireprototypes.baseprotocolhandler)
class httpv2protocolhandler(object): class httpv2protocolhandler(object):
def __init__(self, req, ui, args=None): def __init__(self, req, ui, args=None):
self._req = req self._req = req
self._ui = ui self._ui = ui
self._args = args self._args = args