This is an archive of the discontinued Mercurial Phabricator instance.

tests: work around `tac` not being portable
ClosedPublic

Authored by durin42 on Nov 7 2018, 12:15 PM.

Details

Summary

Introduce a tac.py helper and use it. Sigh.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 7 2018, 12:15 PM
martinvonz added inline comments.
tests/test-fix.t
1125

Could the tool be sort -r? I know that's not generally equivalent to tac, but it seems like it might work here (it's kind of a reasonable fix tool too).

durin42 added inline comments.Nov 7 2018, 1:17 PM
tests/test-fix.t
1125

It probably could, but I don't feel strongly either way. Do you?

martinvonz accepted this revision.Nov 7 2018, 1:24 PM
martinvonz added inline comments.
tests/test-fix.t
1125

Not very, but strongly enough that'd I've tested that the test passes. I can queue this and send a followup.

This revision is now accepted and ready to land.Nov 7 2018, 1:24 PM
This revision was automatically updated to reflect the committed changes.