diff --git a/mercurial/help.py b/mercurial/help.py --- a/mercurial/help.py +++ b/mercurial/help.py @@ -163,14 +163,14 @@ if isinstance(default, fancyopts.customopt): default = default.getdefaultvalue() - if default and not callable(default): + if (default and not callable(default)) or default is False: # default is of unknown type, and in Python 2 we abused # the %s-shows-repr property to handle integers etc. To # match that behavior on Python 3, we do str(default) and # then convert it to bytes. defaultstr = pycompat.bytestr(default) - if default is True: - defaultstr = _("on") + if isinstance(default, bool): + defaultstr = _("on") if default else _("off") desc += _(" (default: %s)") % defaultstr if isinstance(default, list): diff --git a/tests/test-extension.t b/tests/test-extension.t --- a/tests/test-extension.t +++ b/tests/test-extension.t @@ -716,7 +716,7 @@ --profile print command execution profile --version output version information and exit -h --help display help and exit - --hidden consider hidden changesets + --hidden consider hidden changesets (default: off) --pager TYPE when to paginate (boolean, always, auto, or never) (default: auto) @@ -755,7 +755,7 @@ --profile print command execution profile --version output version information and exit -h --help display help and exit - --hidden consider hidden changesets + --hidden consider hidden changesets (default: off) --pager TYPE when to paginate (boolean, always, auto, or never) (default: auto) @@ -1043,7 +1043,7 @@ --profile print command execution profile --version output version information and exit -h --help display help and exit - --hidden consider hidden changesets + --hidden consider hidden changesets (default: off) --pager TYPE when to paginate (boolean, always, auto, or never) (default: auto) @@ -1080,7 +1080,7 @@ --profile print command execution profile --version output version information and exit -h --help display help and exit - --hidden consider hidden changesets + --hidden consider hidden changesets (default: off) --pager TYPE when to paginate (boolean, always, auto, or never) (default: auto) @@ -1155,7 +1155,7 @@ --profile print command execution profile --version output version information and exit -h --help display help and exit - --hidden consider hidden changesets + --hidden consider hidden changesets (default: off) --pager TYPE when to paginate (boolean, always, auto, or never) (default: auto) @@ -1191,7 +1191,7 @@ --profile print command execution profile --version output version information and exit -h --help display help and exit - --hidden consider hidden changesets + --hidden consider hidden changesets (default: off) --pager TYPE when to paginate (boolean, always, auto, or never) (default: auto) diff --git a/tests/test-fix.t b/tests/test-fix.t --- a/tests/test-fix.t +++ b/tests/test-fix.t @@ -104,12 +104,12 @@ options ([+] can be repeated): - --all fix all non-public non-obsolete revisions + --all fix all non-public non-obsolete revisions (default: off) --base REV [+] revisions to diff against (overrides automatic selection, and applies to every revision being fixed) -r --rev REV [+] revisions to fix - -w --working-dir fix the working directory - --whole always fix every line of a file + -w --working-dir fix the working directory (default: off) + --whole always fix every line of a file (default: off) (some details hidden, use --verbose to show complete help) diff --git a/tests/test-help.t b/tests/test-help.t --- a/tests/test-help.t +++ b/tests/test-help.t @@ -440,7 +440,7 @@ --profile print command execution profile --version output version information and exit -h --help display help and exit - --hidden consider hidden changesets + --hidden consider hidden changesets (default: off) --pager TYPE when to paginate (boolean, always, auto, or never) (default: auto) @@ -540,7 +540,7 @@ --profile print command execution profile --version output version information and exit -h --help display help and exit - --hidden consider hidden changesets + --hidden consider hidden changesets (default: off) --pager TYPE when to paginate (boolean, always, auto, or never) (default: auto) @@ -905,7 +905,7 @@ xxxxxxxxxxxxxxxxxxxxxxx (default: 3) -n -- normal desc --newline VALUE line1 line2 - --default-off enable X + --default-off enable X (default: off) --default-on enable Y (default: on) --callableopt VALUE adds foo --customopt VALUE adds bar @@ -2890,7 +2890,7 @@