( )⚙ D5510 narrow: reuse narrowspec.updateworkingcopy() when widening

This is an archive of the discontinued Mercurial Phabricator instance.

narrow: reuse narrowspec.updateworkingcopy() when widening
ClosedPublic

Authored by martinvonz on Jan 7 2019, 3:45 AM.

Details

Summary

The widening of the working copy we do after widening a repo is
practically the same as we do in a repo share after the store
narrowspec has been changed in a different share. Let's reuse the code
for that that we now have in the narrowspec module.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 7 2019, 3:45 AM
martinvonz updated this revision to Diff 13038.Jan 7 2019, 4:18 AM
martinvonz updated this revision to Diff 13059.Jan 7 2019, 2:02 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Jan 16 2019, 7:42 AM

Fixed pyflakes warnings in flight.

hgext/narrow/narrowcommands.py:13: 'mercurial.merge' imported but unused
hgext/narrow/narrowcommands.py:262: local variable 'newmatch' is assigned to but never used
In D5510#82651, @yuja wrote:

Fixed pyflakes warnings in flight.

hgext/narrow/narrowcommands.py:13: 'mercurial.merge' imported but unused
hgext/narrow/narrowcommands.py:262: local variable 'newmatch' is assigned to but never used

Sorry about that, and thanks for fixing!