( )⚙ D5769 tests: alter email `From` line to a value that's consistently parsed

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5769

tests: alter email `From` line to a value that's consistently parsed
ClosedPublic

Authored by durin42 on Jan 30 2019, 7:44 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8c13f7b0ace6: tests: alter email `From` line to a value that's consistently parsed
rHG6b10c51b1b71: tests: alter email `From` line to a value that's consistently parsed
rHG56404e03f57e: tests: alter email `From` line to a value that's consistently parsed
Summary

Python2:

email.header.decode_header('=?UTF-8?q?Rapha=C3=ABl=20Hertzog?= <hertzog@debian.org>')

[('Rapha\xc3\xabl Hertzog', 'utf-8'), ('<hertzog@debian.org>', None)]

Python3:

email.header.decode_header('=?UTF-8?q?Rapha=C3=ABl=20Hertzog?= <hertzog@debian.org>')

[(b'Rapha\xc3\xabl Hertzog', 'utf-8'), (b' <hertzog@debian.org>', None)]

So alter the input to an input that parses to the same result
consistently. After skimming the relevant RFC (1342), I'm not sure if
what we had was valid, or how I could modify it to be more consistent.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 30 2019, 7:44 PM
durin42 planned changes to this revision.Jan 30 2019, 7:48 PM

Oops. I'll be back to this.

durin42 edited the summary of this revision. (Show Details)Jan 30 2019, 8:06 PM
durin42 updated this revision to Diff 13619.
durin42 updated this revision to Diff 13624.Jan 30 2019, 8:09 PM
durin42 updated this revision to Diff 13630.Jan 30 2019, 8:33 PM
pulkit accepted this revision.Feb 1 2019, 1:13 PM
Closed by commit rHG56404e03f57e: tests: alter email `From` line to a value that's consistently parsed (authored by durin42). · Explain WhyFeb 1 2019, 1:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/python3-whitelist (1 line)
Mtests/test-import-git.t (2 lines)

Diff 13674

contrib/python3-whitelist

test-http.t test-http.t
test-hybridencode.py test-hybridencode.py
test-i18n.t test-i18n.t
test-identify.t test-identify.t
test-impexp-branch.t test-impexp-branch.t
test-import-bypass.t test-import-bypass.t
test-import-context.t test-import-context.t
test-import-eol.t test-import-eol.t
test-import-git.t
test-import-merge.t test-import-merge.t
test-import-unknown.t test-import-unknown.t
test-import.t test-import.t
test-imports-checker.t test-imports-checker.t
test-incoming-outgoing.t test-incoming-outgoing.t
test-infinitepush-bundlestore.t test-infinitepush-bundlestore.t
test-infinitepush-ci.t test-infinitepush-ci.t
test-infinitepush.t test-infinitepush.t

tests/test-import-git.t

> +b > +b
> EOF > EOF
applying patch from stdin applying patch from stdin
Test email metadata Test email metadata
$ hg revert -qa $ hg revert -qa
$ hg --encoding utf-8 import - <<EOF $ hg --encoding utf-8 import - <<EOF
> From: =?UTF-8?q?Rapha=C3=ABl=20Hertzog?= <hertzog@debian.org> > From: =?utf-8?q?Rapha=C3=ABl_Hertzog_=3Chertzog=40debian=2Eorg=3E?=
> Subject: [PATCH] =?UTF-8?q?=C5=A7=E2=82=AC=C3=9F=E1=B9=AA?= > Subject: [PATCH] =?UTF-8?q?=C5=A7=E2=82=AC=C3=9F=E1=B9=AA?=
> >
> diff --git a/a b/a > diff --git a/a b/a
> --- a/a > --- a/a
> +++ b/a > +++ b/a
> @@ -1,1 +1,2 @@ > @@ -1,1 +1,2 @@
> a > a
> +a > +a