( )⚙ D5897 test: stabilize test-wireproto-exchangev2.t flaky output

This is an archive of the discontinued Mercurial Phabricator instance.

test: stabilize test-wireproto-exchangev2.t flaky output
ClosedPublic

Authored by lothiraldan on Feb 8 2019, 12:36 PM.

Details

Summary

When running the test suite with multiple processes, we often get flaky
outputs, like here: https://ci.octobus.net/job/MercurialPy2/267/console

-  received frame(size=0; request=1; stream=2; streamflags=; type=command-response; flags=eos)
   add changeset cd2534766bec
   add changeset e96ae20f4188
   add changeset caa2a465451d
+  received frame(size=0; request=1; stream=2; streamflags=; type=command-response; flags=eos)

Instead of simply sorting the clone and pull output, I saved the output in a
separate file and checked the received frame messages on one side and then
the rest of the output on the other side. This way we conserve the order of
messages as it seems important.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Feb 8 2019, 12:36 PM
martinvonz added a subscriber: martinvonz.

This test fails for me too quite frequently, so thanks for fixing! I've added indygreg as reviewer since they know this area best.

This revision was automatically updated to reflect the committed changes.