This is an archive of the discontinued Mercurial Phabricator instance.

uncommit: add config option to keep commit by default
ClosedPublic

Authored by martinvonz on Feb 15 2019, 2:12 PM.

Details

Summary

We have a Google-internal extension that keeps track of "review units"
(like Phabricator reviews, or Gerrit's Change-Id). This information is
stored outside of the commit. It is updated with rewrites. Every now
and then we get reports from users who are confused because `hg
uncommit` lost track of their review. Keeping the empty commit by
default would reduce this confusion. It may also cause confusion about
the empty commit. This patch adds a config option that lets us easily
test both behaviors on our users.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Feb 15 2019, 2:12 PM
martinvonz updated this revision to Diff 14109.Feb 15 2019, 3:19 PM
martinvonz updated this revision to Diff 14148.Feb 20 2019, 3:23 PM
This revision was automatically updated to reflect the committed changes.