( )⚙ D6025 remotefilelog: fix format str, blobsize isn't always a #, can be "(missing)"

This is an archive of the discontinued Mercurial Phabricator instance.

remotefilelog: fix format str, blobsize isn't always a #, can be "(missing)"
ClosedPublic

Authored by spectral on Feb 25 2019, 6:59 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

spectral created this revision.Feb 25 2019, 6:59 PM
pulkit added a subscriber: pulkit.Feb 26 2019, 9:40 AM
pulkit added inline comments.
hgext/remotefilelog/debugcommands.py
279

It was changed to %d because %s % int does not work on Python 3. I think %s % pycompat.bytestr(blobsize) should work on both python versions.

spectral updated this revision to Diff 14249.Feb 26 2019, 4:44 PM
spectral marked an inline comment as done.Feb 26 2019, 4:46 PM
spectral added inline comments.
hgext/remotefilelog/debugcommands.py
279

Changed to use pycompat.bytestr

spectral marked an inline comment as done.Feb 26 2019, 5:12 PM
This revision was automatically updated to reflect the committed changes.