This is an archive of the discontinued Mercurial Phabricator instance.

Differential D6053

walkfilerevs: rename filerevgen() to filerevs() since it's not a generator
ClosedPublic

Authored by martinvonz on Mar 2 2019, 6:32 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGdcbb1b4dc93a: walkfilerevs: rename filerevgen() to filerevs() since it's not a generator

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 2 2019, 6:32 PM
Closed by commit rHGdcbb1b4dc93a: walkfilerevs: rename filerevgen() to filerevs() since it's not a generator (authored by martinvonz). · Explain WhyMar 3 2019, 4:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cmdutil.py (4 lines)

Diff 14318

mercurial/cmdutil.py

Returns the changeset revs that are involved in the file history. Returns the changeset revs that are involved in the file history.
Throws FileWalkError if the file history can't be walked using Throws FileWalkError if the file history can't be walked using
filelogs alone. filelogs alone.
''' '''
wanted = set() wanted = set()
copies = [] copies = []
minrev, maxrev = min(revs), max(revs) minrev, maxrev = min(revs), max(revs)
def filerevgen(filelog, last): def filerevs(filelog, last):
""" """
Only files, no patterns. Check the history of each file. Only files, no patterns. Check the history of each file.
Examines filelog entries within minrev, maxrev linkrev range Examines filelog entries within minrev, maxrev linkrev range
Returns an iterator yielding (linkrev, parentlinkrevs, copied) Returns an iterator yielding (linkrev, parentlinkrevs, copied)
tuples in backwards order tuples in backwards order
""" """
cl_count = len(repo) cl_count = len(repo)
last = len(filelog) - 1 last = len(filelog) - 1
else: else:
last = filelog.rev(node) last = filelog.rev(node)
# keep track of all ancestors of the file # keep track of all ancestors of the file
ancestors = {filelog.linkrev(last)} ancestors = {filelog.linkrev(last)}
# iterate from latest to oldest revision # iterate from latest to oldest revision
for rev, flparentlinkrevs, copied in filerevgen(filelog, last): for rev, flparentlinkrevs, copied in filerevs(filelog, last):
if not follow: if not follow:
if rev > maxrev: if rev > maxrev:
continue continue
else: else:
# Note that last might not be the first interesting # Note that last might not be the first interesting
# rev to us: # rev to us:
# if the file has been changed after maxrev, we'll # if the file has been changed after maxrev, we'll
# have linkrev(last) > maxrev, and we still need # have linkrev(last) > maxrev, and we still need