This is an archive of the discontinued Mercurial Phabricator instance.

i18n-ja: correct translation of "committing"
AbandonedPublic

Authored by matvore on Mar 6 2019, 10:19 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

The previous translation considered the English word to mean "committing is
currently happening" but it actually meant "for purposes of committing."

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

matvore created this revision.Mar 6 2019, 10:19 PM
yuja added a subscriber: yuja.Mar 11 2019, 9:46 AM

Maybe need a pullreq? We can't review i18n messages.

https://www.mercurial-scm.org/wiki/TranslatingMercurial#Existing_Translations

-msgstr "secret フェーズでコミット中"
+msgstr "secret フェーズでコミットします"

Perhaps, it should just remove the "中". The Japanese translation appears
to avoid using desu/masu.

In D6081#89058, @yuja wrote:

Maybe need a pullreq? We can't review i18n messages.

Done: https://bitbucket.org/foozy/mercurial-translation-ja/pull-requests/1/

https://www.mercurial-scm.org/wiki/TranslatingMercurial#Existing_Translations

-msgstr "secret フェーズでコミット中"
+msgstr "secret フェーズでコミットします"

Perhaps, it should just remove the "中". The Japanese translation appears
to avoid using desu/masu.

Done in pull request. There was another flag description for --close-branch. I fixed this to not have "します." Now all the flag descriptions in "hg help commit" (including -v ones) are consistent.

Matt, could you abandon these two reviews? That would clean up our dashboard a little (there are lots of obsolete reviews there, so not a big deal).

matvore abandoned this revision.May 10 2019, 12:58 PM