diff --git a/contrib/check-code.py b/contrib/check-code.py --- a/contrib/check-code.py +++ b/contrib/check-code.py @@ -119,7 +119,8 @@ (r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'), (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w', "use egrep for extended grep syntax"), - (r'/bin/', "don't use explicit paths for tools"), + (r'(? \1)", rephere), - (r"( +)(#([^\n]*\S)?)", repcomment), + (r"( +)(#([^!][^\n]*\S)?)", repcomment), ] pypats = [ diff --git a/tests/test-editor-filename.t b/tests/test-editor-filename.t --- a/tests/test-editor-filename.t +++ b/tests/test-editor-filename.t @@ -5,7 +5,7 @@ Create an editor that writes its arguments to stdout and set it to $HGEDITOR. $ cat > editor.sh << EOF - > #!/bin/bash + > #!/bin/sh > echo "\$@" > exit 1 > EOF