This is an archive of the discontinued Mercurial Phabricator instance.

crecord: redraw the screen when starting up chunkselector
ClosedPublic

Authored by spectral on Mar 13 2019, 11:17 PM.

Details

Summary

Failure to do this can cause screen corruption like:

<headerline>
 [X] filename.cc
<several blank lines>
<output from previous iteration of split that happened to be here>

I believe this might only happen in some terminals, and maybe only when using
the "alternate screen". Regardless of the exact conditions to reproduce, it
should be safe to always clear it when starting up and is probably the correct
thing to do anyway :)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Mar 13 2019, 11:17 PM
martinvonz added inline comments.
mercurial/crecord.py
536–537

I assume this patch was based on some local commit that we don't have in core (and don't want in core :)). Can you rebase it to @ and update?

spectral updated this revision to Diff 14491.Mar 14 2019, 1:56 AM
spectral added inline comments.Mar 14 2019, 1:57 AM
mercurial/crecord.py
536–537

D6129, apparently... I'll see myself to the shamecube.

This revision was automatically updated to reflect the committed changes.