_forwardchunks is used to compensate for getbundle protocol deficits.
Since it transparently decodes the payload, it also needs to remove the
corresponding compression parameter in case the server decides to send
one. This the wire protocol part of issue 5990.
Details
Details
- Reviewers
- None
- Group Reviewers
hg-reviewers - Commits
- rHG29569f2db929: bundle2: handle compression in _forwardchunks
rHG6b94f8249eaf: bundle2: handle compression in _forwardchunks
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Ugh I'm sorry - I evidently reviewed this and never pushed submit. :(
mercurial/bundle2.py | ||
---|---|---|
846 | so...what's going on with oparams here? should it be outparams? (is there more to this series that would get this code covered by tests?) |
mercurial/bundle2.py | ||
---|---|---|
846 | Yes, left-over from earlier rename round. I think the code should handle multiple parameters, since I have no idea when we might run into them. At the same time, I have no idea right now how to test that case. |
so...what's going on with oparams here? should it be outparams?
(is there more to this series that would get this code covered by tests?)